From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] misc: don't use hwaddr as a type in trace events
Date: Tue, 6 Mar 2018 13:42:14 +0000 [thread overview]
Message-ID: <CAFEAcA98ZTXqXqtHFOaEvwCbO=206u3jNjN2MDq31m4d=bwkOA@mail.gmail.com> (raw)
In-Reply-To: <20180306133842.GH6163@redhat.com>
On 6 March 2018 at 13:38, Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Tue, Mar 06, 2018 at 01:33:42PM +0000, Peter Maydell wrote:
>> If the type isn't "hwaddr" then HWADDR_PRIx is the wrong
>> format string macro -- those should change to PRIx64.
>
> Eeek, that HWADDR_PRIx macro is used throughout this file, sometimes
> even with uint32_t as the arg !
Mmm, it's used where PRIx64 should be, but I think only for uint64_t
arguments; I can't see a uint32_t one. hw/ide/trace-events also has
a couple of HWADDR_PRIx uses.
thanks
-- PMM
next prev parent reply other threads:[~2018-03-06 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 13:24 [Qemu-trivial] [PATCH] misc: don't use hwaddr as a type in trace events Daniel P. Berrangé
2018-03-06 13:33 ` Peter Maydell
2018-03-06 13:38 ` Daniel P. Berrangé
2018-03-06 13:42 ` Peter Maydell [this message]
2018-03-06 14:14 ` [Qemu-trivial] [Qemu-devel] " Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA98ZTXqXqtHFOaEvwCbO=206u3jNjN2MDq31m4d=bwkOA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).