qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] doc/memory.txt: fix typo
Date: Fri, 26 Feb 2016 11:17:35 +0000	[thread overview]
Message-ID: <CAFEAcA_vs62TV43cmT=-SQ75ySt3U29idyfrwvB5eiPi5M0vbA@mail.gmail.com> (raw)
In-Reply-To: <56D0333A.2000605@cn.fujitsu.com>

On 26 February 2016 at 11:12, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> On 02/26/2016 07:03 PM, Peter Maydell wrote:
>> Why is this patch touching all these ascii art diagrams? If you want
>> to change them, that's a different patch, but I don't see any need to.
>> In fact you seem to have lost some of the [] from your version, so your
>> change doesn't look like an improvement to me.

> well, the diagram seem not aligned so well, so I did the modification.

The lines
        0      1000   2000   3000   4000   5000   6000   7000    8000
        |------|------|------|------|------|------|------|-------|

have one stray extra '-' in the 7000..8000 part (and so an
extra ' ' before '8000'), both other than that the diagram
itself looks correct to me.

thanks
-- PMM


      reply	other threads:[~2016-02-26 11:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 10:59 [Qemu-trivial] [PATCH v2] doc/memory.txt: fix typo Cao jin
2016-02-26 11:03 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2016-02-26 11:12   ` Cao jin
2016-02-26 11:17     ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_vs62TV43cmT=-SQ75ySt3U29idyfrwvB5eiPi5M0vbA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).