[Qemu-trivial] [PATCH v3 1/2] tracetool: dtrace: handle in and next reserved words

[Qemu-trivial] [PATCH v3 1/2] tracetool: dtrace: handle in and next reserved words

[Alon Levy]

Signed-off-by: Alon Levy <alevy@redhat.com>
---

I think I need a qemu-trivial-review too ;)

v3:
 added self    (Lee Essen)
 use post '_'  (Stefan Hajnoczi)
 use case/esca (Eric Blake & Peter Maydell)

 scripts/tracetool |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/scripts/tracetool b/scripts/tracetool
index 65bd0a1..ab788f2 100755
--- a/scripts/tracetool
+++ b/scripts/tracetool
@@ -494,10 +494,12 @@ EOF
     i=1
     for arg in $arglist
     do
-        # 'limit' is a reserved keyword
-        if [ "$arg" = "limit" ]; then
-          arg="_limit"
-        fi
+        # postfix reserved words with '_'
+        case "$arg" in
+            limit|in|next|self)
+                arg="${arg}_"
+                ;;
+        esac
         cat <<EOF
   $arg = \$arg$i;
 EOF
-- 
1.7.9.3

[Qemu-trivial] [PATCH 2/2] tracetool: dtrace: warn on reserved word usage

[Alon Levy]

Signed-off-by: Alon Levy <alevy@redhat.com>
---
 scripts/tracetool |    1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/tracetool b/scripts/tracetool
index ab788f2..c2aed8f 100755
--- a/scripts/tracetool
+++ b/scripts/tracetool
@@ -497,6 +497,7 @@ EOF
         # postfix reserved words with '_'
         case "$arg" in
             limit|in|next|self)
+                echo "reserved word used in line: $1" 1>&2
                 arg="${arg}_"
                 ;;
         esac
-- 
1.7.9.3

Re: [Qemu-trivial] [PATCH v3 1/2] tracetool: dtrace: handle in and next reserved words

[Stefan Hajnoczi]

On Thu, Mar 29, 2012 at 10:35 PM, Alon Levy <alevy@redhat.com> wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>
> I think I need a qemu-trivial-review too ;)
>
> v3:
>  added self    (Lee Essen)
>  use post '_'  (Stefan Hajnoczi)
>  use case/esca (Eric Blake & Peter Maydell)
>
>  scripts/tracetool |   10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Thanks, I have merged this patch.

Stefan

Re: [Qemu-trivial] [PATCH 2/2] tracetool: dtrace: warn on reserved word usage

[Stefan Hajnoczi]

On Thu, Mar 29, 2012 at 10:35 PM, Alon Levy <alevy@redhat.com> wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>  scripts/tracetool |    1 +
>  1 file changed, 1 insertion(+)

I have not merged this patch because I don't want to avoid adding
warnings that are only visible when using a specific backend.

The problem is that offending trace-events lines will be added and
later on someone who uses dtrace will find a whole list of new
warnings.

Stefan