From: Alistair Francis <alistair.francis@xilinx.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
Alistair Francis <alistair.francis@xilinx.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()
Date: Fri, 22 Dec 2017 11:57:20 -0800 [thread overview]
Message-ID: <CAKmqyKPyL8B5ZjEUePkqVbzP8kVmM48vWML41PRXVVO7LVmMpg@mail.gmail.com> (raw)
In-Reply-To: <1cfb1217-e32d-8e91-da46-07f1c72be77f@redhat.com>
On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth <thuth@redhat.com> wrote:
> On 22.12.2017 16:37, Markus Armbruster wrote:
>> Second thoughts...
>>
>> Alistair Francis <alistair.francis@xilinx.com> writes:
> [...]
>>> #include "qemu/osdep.h"
>>> +#include "qemu/error-report.h"
>>> #include "qapi/error.h"
>>> #include "qemu-common.h"
>>> #include "cpu.h"
>>> @@ -1311,8 +1312,8 @@ static void omap_prcm_apll_update(struct omap_prcm_s *s)
>>> /* TODO: update clocks */
>>>
>>> if (mode[0] == 1 || mode[0] == 2 || mode[1] == 1 || mode[1] == 2)
>>> - fprintf(stderr, "%s: bad EN_54M_PLL or bad EN_96M_PLL\n",
>>> - __func__);
>>> + error_report("%s: bad EN_54M_PLL or bad EN_96M_PLL",
>>> + __func__);
>>> }
>>
>> This one's different: we neither exit() nor return a "failed" status to
>> the caller.
>>
>> We get here when the guest writes something funny to a certain
>> memory-mapped I/O register. In other words, it's guest misbehavior, not
>> a user error. I doubt it should be reported with error_report().
>> Peter, do we have a canonical way to report or log guest misbehavior?
>
> qemu_log_mask(LOG_GUEST_ERROR, ...) ?
That seems like the best option to me.
Alistair
>
> Thomas
>
>
next prev parent reply other threads:[~2017-12-22 19:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 17:22 [Qemu-trivial] [PATCH v6 00/29] Remove some of the fprintf(stderr, "* Alistair Francis
2017-12-20 17:22 ` [Qemu-trivial] [PATCH v6 01/29] audio: Replace AUDIO_FUNC with __func__ Alistair Francis
2017-12-20 17:22 ` [Qemu-trivial] [PATCH v6 02/29] Replace all occurances of __FUNCTION__ " Alistair Francis
2017-12-20 17:22 ` [Qemu-trivial] [PATCH v6 03/29] Fixes after renaming __FUNCTION__ to __func__ Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report() Alistair Francis
2017-12-22 15:21 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2017-12-22 15:37 ` Markus Armbruster
2017-12-22 17:17 ` Thomas Huth
2017-12-22 19:57 ` Alistair Francis [this message]
2017-12-22 20:30 ` Markus Armbruster
2017-12-22 20:58 ` Alistair Francis
2018-01-02 12:59 ` Markus Armbruster
2018-01-09 0:32 ` Alistair Francis
2018-01-09 15:31 ` Thomas Huth
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 05/29] hw/dma: " Alistair Francis
2017-12-22 15:21 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 06/29] hw/gpio: " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 07/29] hw/i2c: " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 09/29] hw/ide: " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 10/29] hw/intc: " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 11/29] hw/ipmi: " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 12/29] hw/isa: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 13/29] hw/lm32: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 14/29] hw/mips: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 15/29] hw/moxie: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 16/29] hw/nios2: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 17/29] hw/nvram: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 18/29] hw/openrisc: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 19/29] hw/pci*: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 20/29] hw/ppc: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 21/29] hw/s390x: " Alistair Francis
2018-01-09 17:45 ` [Qemu-trivial] [Qemu-devel] " Cornelia Huck
2018-01-09 18:09 ` Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 23/29] hw/sd: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 24/29] hw/sparc*: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 25/29] hw/ssi: " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 26/29] hw/timer: " Alistair Francis
2017-12-20 17:25 ` [Qemu-trivial] [PATCH v6 27/29] hw/xen*: " Alistair Francis
2017-12-20 17:25 ` [Qemu-trivial] [PATCH v6 28/29] tcg: " Alistair Francis
2017-12-20 17:25 ` [Qemu-trivial] [PATCH v6 29/29] target: Use qemu_log() instead of fprintf(stderr, ...) Alistair Francis
[not found] ` <97bff6488fbc4c6b2c10879798aa149a43426fd9.1513790495.git.alistair.francis@xilinx.com>
2017-12-20 22:10 ` [Qemu-trivial] [PATCH v6 08/29] hw/i386: Replace fprintf(stderr, "*\n" with error_report() Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKPyL8B5ZjEUePkqVbzP8kVmM48vWML41PRXVVO7LVmMpg@mail.gmail.com \
--to=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).