* [PATCH] qtest/fw-cfg: remove compiled out code
@ 2025-01-01 8:15 Ani Sinha
2025-01-01 8:27 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Ani Sinha @ 2025-01-01 8:15 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Gerd Hoffmann, Fabiano Rosas,
Laurent Vivier, Paolo Bonzini
Cc: Ani Sinha, qemu-trivial, qemu-devel
Remove code that is already compiled out. This prevents confusion.
CC: qemu-trivial@nongnu.org
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
tests/qtest/fw_cfg-test.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tests/qtest/fw_cfg-test.c b/tests/qtest/fw_cfg-test.c
index 5dc807ba23..e48b34afa5 100644
--- a/tests/qtest/fw_cfg-test.c
+++ b/tests/qtest/fw_cfg-test.c
@@ -243,12 +243,6 @@ int main(int argc, char **argv)
qtest_add_func("fw_cfg/ram_size", test_fw_cfg_ram_size);
qtest_add_func("fw_cfg/nographic", test_fw_cfg_nographic);
qtest_add_func("fw_cfg/nb_cpus", test_fw_cfg_nb_cpus);
-#if 0
- qtest_add_func("fw_cfg/machine_id", test_fw_cfg_machine_id);
- qtest_add_func("fw_cfg/kernel", test_fw_cfg_kernel);
- qtest_add_func("fw_cfg/initrd", test_fw_cfg_initrd);
- qtest_add_func("fw_cfg/boot_device", test_fw_cfg_boot_device);
-#endif
qtest_add_func("fw_cfg/max_cpus", test_fw_cfg_max_cpus);
qtest_add_func("fw_cfg/numa", test_fw_cfg_numa);
qtest_add_func("fw_cfg/boot_menu", test_fw_cfg_boot_menu);
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qtest/fw-cfg: remove compiled out code
2025-01-01 8:15 [PATCH] qtest/fw-cfg: remove compiled out code Ani Sinha
@ 2025-01-01 8:27 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-01-01 8:27 UTC (permalink / raw)
To: Ani Sinha
Cc: Gerd Hoffmann, Fabiano Rosas, Laurent Vivier, Paolo Bonzini,
qemu-trivial, qemu-devel
On Wed, 1 Jan 2025 at 09:16, Ani Sinha <anisinha@redhat.com> wrote:
>
> Remove code that is already compiled out. This prevents confusion.
>
> CC: qemu-trivial@nongnu.org
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> tests/qtest/fw_cfg-test.c | 6 ------
> 1 file changed, 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-01 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-01 8:15 [PATCH] qtest/fw-cfg: remove compiled out code Ani Sinha
2025-01-01 8:27 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).