From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1rLQGj-0005Ne-EF for mharc-qemu-trivial@gnu.org; Thu, 04 Jan 2024 11:08:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLQGh-0005N4-Ti; Thu, 04 Jan 2024 11:08:28 -0500 Received: from mgamail.intel.com ([134.134.136.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLQGf-0007rm-Av; Thu, 04 Jan 2024 11:08:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704384505; x=1735920505; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bP25CFmB5ICIWnAQeHR2h136ykKPR/ZLhxWl27+NbLU=; b=VgqCoJUa+F6T+yGEjeEak+1QxHK1reQ5vhzdc8pshTixFgkQOLQeFi6m MjwKtu8COjKcDVQarOBwSY3HfhZ69AvH4AqiySons5NZieZ6AC/eLI4Ls oeb5vIYwfddiqjTMfqIOyOpZMAhznl8Qok3cvjhaSOrhczsIN7MoA7Nyo twIMH/99xBrbWHk4Mws6k1gsriE53gWxPaYO5PQe6PY3TunlORNZOvjiw 9oWzBoCmvx8cH6O4NLDLX21xJ7060gQVhyfmEXQFZUS9Kh5PJv3aV28S4 Btz/krqIqFYult1KP/4+vP+1joRYbY9AiTIR2zOQYnCX0P8VnQMYUAJLb g==; X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="387738508" X-IronPort-AV: E=Sophos;i="6.04,331,1695711600"; d="scan'208";a="387738508" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2024 08:08:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="846293747" X-IronPort-AV: E=Sophos;i="6.04,331,1695711600"; d="scan'208";a="846293747" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by fmsmga008.fm.intel.com with ESMTP; 04 Jan 2024 08:08:10 -0800 Date: Fri, 5 Jan 2024 00:21:02 +0800 From: Zhao Liu To: Samuel Tardieu Cc: Michael Tokarev , Laurent Vivier , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Paolo Bonzini , Thomas Huth , Richard Henderson , Darren Kenny , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-trivial@nongnu.org, Zhenyu Wang , Zhao Liu , Yongwei Ma , qemu-devel@nongnu.org Subject: Re: [PATCH v2] scripts/checkpatch: Support codespell checking Message-ID: References: <20231215103448.3822284-1-zhao1.liu@linux.intel.com> <87frze5vlc.fsf@telecom-paris.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87frze5vlc.fsf@telecom-paris.fr> Received-SPF: none client-ip=134.134.136.20; envelope-from=zhao1.liu@linux.intel.com; helo=mgamail.intel.com X-Spam_score_int: -69 X-Spam_score: -7.0 X-Spam_bar: ------- X-Spam_report: (-7.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.691, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2024 16:08:28 -0000 Hi Samuel, On Wed, Jan 03, 2024 at 03:36:59PM +0100, Samuel Tardieu wrote: > Date: Wed, 03 Jan 2024 15:36:59 +0100 > From: Samuel Tardieu > Subject: Re: [PATCH v2] scripts/checkpatch: Support codespell checking > > > + --codespell Use the codespell dictionary for > > spelling/typos > > + (default:$codespellfile) > > Nitpick: I would have used a space after ":". OK! I'll add it to improve the readability of the help printout. > > > + # If /usr/share/codespell/dictionary.txt is not present, try to find > > it > > + # under codespell's install directory: > > /data/dictionary.txt > > This works correctly on my NixOS system using a non-FHS layout and properly > locates the codespell file. > > This patch made me find a typo in one of my commit messages. > > Tested-by: Samuel Tardieu > Thanks! Good to know this enhancement can help you! Regards, Zhao