From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1rRzsR-0004wP-9X for mharc-qemu-trivial@gnu.org; Mon, 22 Jan 2024 14:22:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRzsN-0004uN-3B for qemu-trivial@nongnu.org; Mon, 22 Jan 2024 14:22:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRzsL-0005Dt-8Y for qemu-trivial@nongnu.org; Mon, 22 Jan 2024 14:22:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705951347; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fkFnR5s5hHboIXmh32DuvnLiAWHl6aY0Xd0TaXengGQ=; b=bJs8dJhOve/T5VODvY9U3Y4QcQKZpVswFVLdlnPJ90aaSgiAFPAJ/++HpbY7IHJPajhKxN YOHGnFZWGPO+la80wkT36Q6r45uxi1aCtFRz6huDGfDAF8e924bBBevFG7G8CprbgfXQy4 kiqHsqKe4xBLHSey6dqD8i5o1xJWsNY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-6GEUQM0kMJ6igf4ns0CbSw-1; Mon, 22 Jan 2024 14:22:24 -0500 X-MC-Unique: 6GEUQM0kMJ6igf4ns0CbSw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 698AE29AC004; Mon, 22 Jan 2024 19:22:24 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D2F3927; Mon, 22 Jan 2024 19:22:22 +0000 (UTC) Date: Mon, 22 Jan 2024 19:22:20 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Paolo Bonzini , Stefan Weil , qemu-trivial@nongnu.org Subject: Re: [PATCH 0/5] util/uri: Simplify the code, remove unused functions Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20240122191753.103118-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240122191753.103118-1-thuth@redhat.com> User-Agent: Mutt/2.2.10 (2023-03-25) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.289, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2024 19:22:33 -0000 On Mon, Jan 22, 2024 at 08:17:48PM +0100, Thomas Huth wrote: > The URI function uri_string_unescape() has some overlap with functions > from the glib, so we can simplify our code here quite a bit. > While at it, I also noticed that there are many unused functions in > here which we likely can drop nowadays (it's better to use the functions > from glib anyway). > > Thomas Huth (5): > util/uri: Remove the unused "target" argument from > uri_string_unescape() > util/uri: Simplify uri_string_unescape() > util/uri: Remove the uri_string_escape() function > util/uri: Remove unused functions uri_resolve() and > uri_resolve_relative() > util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM() > > include/qemu/uri.h | 5 +- > util/uri.c | 843 +-------------------------------------------- > 2 files changed, 16 insertions(+), 832 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|