From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hUtYu-0000aM-Vf for mharc-qemu-trivial@gnu.org; Sun, 26 May 2019 09:51:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUtYq-0000YV-Db for qemu-trivial@nongnu.org; Sun, 26 May 2019 09:51:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUtYp-00022V-9F for qemu-trivial@nongnu.org; Sun, 26 May 2019 09:51:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:2242) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hUtYe-0001BL-3J; Sun, 26 May 2019 09:51:28 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 May 2019 06:51:15 -0700 Received: from likexu-mobl1.ccr.corp.intel.com (HELO [10.255.31.212]) ([10.255.31.212]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 26 May 2019 06:51:13 -0700 From: Like Xu To: qemu-trivial@nongnu.org Cc: Peter Maydell , Eduardo Habkost , qemu-devel@nongnu.org, "Dr . David Alan Gilbert" , Alistair Francis , Igor Mammedov References: <20190518205428.90532-1-like.xu@linux.intel.com> Organization: Intel OTC Message-ID: Date: Sun, 26 May 2019 21:51:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190518205428.90532-1-like.xu@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.20 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 00/10] Refactor cpu topo into machine properties X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 May 2019 13:51:41 -0000 On 2019/5/19 4:54, Like Xu wrote: > This patch series make existing cores/threads/sockets into machine > properties and get rid of global smp_* variables they use currently. > > The purpose of getting rid of globals is disentangle layer violations and > let's do it one step at a time by replacing the smp_foo with qdev_get_machine() > as few calls as possible and delay other related refactoring efforts. > Hi Eduardo & Igor, Do you have any comments on this new version of CpuTopology refactoring? With this series of patch, we may move forward to review [Qemu-devel] [PATCH v2 0/5] Introduce cpu die topology and enable CPUID.1F for i386. Thanks, Like Xu > ==changelog== > > v3: > > - rephrase commit messages > - s/of/of present/ for CpuTopology comment > - drop reduanct arguments such as cpu_type > - use ms instead of macs in migration context > - rebase to commit 1b46b4daa6 >