qemu-trivial.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Nir Lichtman <nir@lichtman.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	QEMU Trivial <qemu-trivial@nongnu.org>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] docs/system/keys: fix incorrect reset scaling key binding
Date: Tue, 7 Oct 2025 13:47:50 +0200	[thread overview]
Message-ID: <a67e9c85-02ba-415c-b178-4e4d6366c4fe@redhat.com> (raw)
In-Reply-To: <20250910102351.GA1782682@lichtman.org>

On 10/09/2025 12.23, Nir Lichtman wrote:
> On Wed, Sep 10, 2025 at 10:38:43AM +0200, Gerd Hoffmann wrote:
>> On Tue, Sep 09, 2025 at 11:15:54AM +0200, Thomas Huth wrote:
>>> On 15/08/2025 11.00, Nir Lichtman wrote:
>>>> Fix incorrect key binding for resetting the graphical frontends scaling
>>>>
>>>> Signed-off-by: Nir Lichtman <nir@lichtman.org>
>>>> ---
>>>>    docs/system/keys.rst.inc | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
>>>> index c28ae1a..3b5307b 100644
>>>> --- a/docs/system/keys.rst.inc
>>>> +++ b/docs/system/keys.rst.inc
>>>> @@ -21,7 +21,7 @@ while ``-display sdl,grab-mod=rctrl`` changes it to the right :kbd:`Ctrl` key.
>>>>      * - :kbd:`Ctrl+Alt+-`
>>>>        - Shrink the screen
>>>> -  * - :kbd:`Ctrl+Alt+u`
>>>> +  * - :kbd:`Ctrl+Alt+0`
>>>>        - Restore the screen's un-scaled dimensions
>>>
>>>   Hi,
>>>
>>> this unfortunately seems to depend on the graphical front-end: For "-display
>>> gtk", it's ctrl-alt-0 indeed, but for "-display sdl", it's ctrl-alt-u
>>> instead.
>>>
>>> Should we unify them? If so, which is the better key combination?
>>
>> Established convention in various apps is '+' for zoom in, '-' for zoom
>> out, and '0' for reset to 100% (each combined with the hotkey
>> modifier(s)).  So when changing hotkeys we should follow that I think,
>> i.e. switch SDL to Ctrl+Alt+0.
> 
> I'll send a patch fixing SDL to use CTRL+ALT+0

Now that the patch for the SDL backend got merged:

Reviewed-by: Thomas Huth <thuth@redhat.com>



       reply	other threads:[~2025-10-07 11:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250815090025.GA1464436@lichtman.org>
     [not found] ` <e7dcf4c0-e3c5-4a0f-8d23-a7786dac21fd@redhat.com>
     [not found]   ` <o4nzr4rw7hfo4nksowiy5nnfjkwfszx4dwcn6mo5oxcu5hilwq@tkfasphulhsc>
     [not found]     ` <20250910102351.GA1782682@lichtman.org>
2025-10-07 11:47       ` Thomas Huth [this message]
2025-10-10  7:56         ` [PATCH] docs/system/keys: fix incorrect reset scaling key binding Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a67e9c85-02ba-415c-b178-4e4d6366c4fe@redhat.com \
    --to=thuth@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=nir@lichtman.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).