From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] configure: Set $PYTHON in the configuration of the optionroms
Date: Wed, 14 Jan 2026 11:56:30 +0000 [thread overview]
Message-ID: <aWeEbq2CSQESPBH3@redhat.com> (raw)
In-Reply-To: <20260114083306.18172-1-thuth@redhat.com>
On Wed, Jan 14, 2026 at 09:33:06AM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> pc-bios/optionrom/Makefile uses $(PYTHON) for running a Python script,
> but this variable is never initialized here. So the script gets run
> via its shebang line - which fails if the "python3" binary is not
> available on the system. To fix this, write the PYTHON configuration
> to the config.mak file of the optionroms.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2026-01-14 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 8:33 [PATCH] configure: Set $PYTHON in the configuration of the optionroms Thomas Huth
2026-01-14 11:56 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWeEbq2CSQESPBH3@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox