From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47B54D3900B for ; Wed, 14 Jan 2026 18:41:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vg5nb-0008Lu-Eh; Wed, 14 Jan 2026 13:40:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg5nM-0008I3-0H for qemu-trivial@nongnu.org; Wed, 14 Jan 2026 13:40:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg5nI-0000P5-EM for qemu-trivial@nongnu.org; Wed, 14 Jan 2026 13:40:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768416034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=suBJ91a67SF+lDuwudYjmVALWSOmrrBH9zPJROgLgHk=; b=iX/DEMeKZaFzu7HEEnJsfF/2Oph6pxfLT5N79ActEYwiZMl4pMMqWLh1eBAw2hwR0vm7UR hPcut2hPJznwIKLstAFGNjKGqHSC6cQuYbNwkJD8W56Tf0ecEY9zZOWU8Yhx4PC+Gg96tX pvJv9+3CHzXSEUwUqFLpVIwiI5KPnEE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-k15g0GATOLuX6Jb8hGvDPg-1; Wed, 14 Jan 2026 13:40:32 -0500 X-MC-Unique: k15g0GATOLuX6Jb8hGvDPg-1 X-Mimecast-MFC-AGG-ID: k15g0GATOLuX6Jb8hGvDPg_1768416031 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 69301195606D; Wed, 14 Jan 2026 18:40:31 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.253]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 74EB730002D8; Wed, 14 Jan 2026 18:40:29 +0000 (UTC) Date: Wed, 14 Jan 2026 12:40:27 -0600 From: Eric Blake To: Thomas Huth Cc: Kevin Wolf , qemu-block@nongnu.org, Hanna Reitz , qemu-devel@nongnu.org, qemu-trivial@nongnu.org Subject: Re: [PATCH] tests/qemu-iotests: Use "gsed" for expressions that require GNU sed Message-ID: References: <20260113141415.97281-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260113141415.97281-1-thuth@redhat.com> User-Agent: NeoMutt/20251211 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org On Tue, Jan 13, 2026 at 03:14:15PM +0100, Thomas Huth wrote: > From: Thomas Huth > > A bunch of tests are currently failing e.g. on FreeBSD like this: > > This happens because the sed statements require GNU sed. Let's use > gsed in these spots to get it fixed. gsed is not installed by that name on all machines... \me checks Ah, common.rc defines a function gsed that calls the appropriate sed. No objection to the patch as-is, although a mention of the common.rc existence of gsed might help the next reader who sees just the commit message and wonders about it like I did. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org