From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1l591p-0007yF-Hi for mharc-qemu-trivial@gnu.org; Thu, 28 Jan 2021 10:16:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l591n-0007vq-1G for qemu-trivial@nongnu.org; Thu, 28 Jan 2021 10:16:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l591j-0002mz-Dy for qemu-trivial@nongnu.org; Thu, 28 Jan 2021 10:16:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611846963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DYMmxn0WY/aIAyBB2C/ZnyCi4mWfwlYJFky34Bmk+Q4=; b=LJFWEFqoa/F54/Q7iL5k/zFKvcErk8+HdE5Vc4wiwYB6aZ7RW3PS00ljxj6sTOYHcLxt1w ER6pL2kpARSFEMWzl+EC+RSOpBTODi7Rjd4zRO43NTAM7glPrCPfeo+SK6xFaBWZzl0Dwb dXoSxP8RNq0uan2Ir/6WtsTBun1FNx8= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-I6byiPvfOUiL_pMLLKze2w-1; Thu, 28 Jan 2021 10:16:02 -0500 X-MC-Unique: I6byiPvfOUiL_pMLLKze2w-1 Received: by mail-ed1-f71.google.com with SMTP id f4so3322912eds.5 for ; Thu, 28 Jan 2021 07:16:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DYMmxn0WY/aIAyBB2C/ZnyCi4mWfwlYJFky34Bmk+Q4=; b=Ns3vVOlNOQqxlC6vpO95gAs4AmA5vEtQVltFAgaj5OmmxPWYQIBu5FfrgzEOESCVt0 KTwk3Z1E1NiF1iJL2RfgDUSFWSVGUQr8RWOFgys8vuBDJmfI033O2vjtuExVTNGMon1y oZKHLrV+xJQ6K+bZbAE3vzsbYhvRN+acq0SZyf3JJw795fBFarhoUWWWEbxdLD1gP04K Jq5WL1Zwuefkj8TX9NRb1QP+0X0qrYAFIg8xxKxCKoXTqDLc5i5IDaraXODbqGz6DHqU UukQjpwLCD12/wtCCsaqDy4XPy17lMXVjhHtgoFmZfAFFm2n7egbzfMZL1B/saVtJ3Om mUjg== X-Gm-Message-State: AOAM532aLtuK5nsgUfMCI/WWP296qiqfftmltWxfiPA81Yv/i+GtRzQr QEzXj5CPc2GiY43QR3xhQa5kPdfVtJur1TQcY9MBYEIq7v1v0bqMJvQ2BfLysIGzruM+UKw6M+2 F32AsRXFIQIRlvzbldA== X-Received: by 2002:a17:906:f991:: with SMTP id li17mr11746436ejb.31.1611846961178; Thu, 28 Jan 2021 07:16:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvvH5DkbiANuzqAUhjdEjO07V5dfsXS5adFl/7E3xjgMEq8N2UYhT3cJpmjqCo5tV3F0R0rw== X-Received: by 2002:a17:906:f991:: with SMTP id li17mr11746426ejb.31.1611846961006; Thu, 28 Jan 2021 07:16:01 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id y8sm3040908edd.97.2021.01.28.07.15.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 07:16:00 -0800 (PST) Subject: Re: [PATCH] docs: don't install corresponding man page if guest agent is disabled To: Stefan Reiter , qemu-trivial@nongnu.org Cc: qemu-devel@nongnu.org, Peter Maydell , Markus Armbruster References: <20210128145801.14384-1-s.reiter@proxmox.com> From: Paolo Bonzini Message-ID: Date: Thu, 28 Jan 2021 16:15:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210128145801.14384-1-s.reiter@proxmox.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.252, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 15:16:11 -0000 On 28/01/21 15:58, Stefan Reiter wrote: > No sense outputting the qemu-ga and qemu-ga-ref man pages when the guest > agent binary itself is disabled. This mirrors behaviour from before the > meson switch. > > Signed-off-by: Stefan Reiter > --- > docs/meson.build | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/docs/meson.build b/docs/meson.build > index bb14eaebd3..f84306ba7e 100644 > --- a/docs/meson.build > +++ b/docs/meson.build > @@ -46,9 +46,11 @@ if build_docs > meson.source_root() / 'docs/sphinx/qmp_lexer.py', > qapi_gen_depends ] > > + have_ga = have_tools and config_host.has_key('CONFIG_GUEST_AGENT') > + > man_pages = { > - 'qemu-ga.8': (have_tools ? 'man8' : ''), > - 'qemu-ga-ref.7': 'man7', > + 'qemu-ga.8': (have_ga ? 'man8' : ''), > + 'qemu-ga-ref.7': (have_ga ? 'man7' : ''), > 'qemu-qmp-ref.7': 'man7', > 'qemu-storage-daemon-qmp-ref.7': (have_tools ? 'man7' : ''), > 'qemu-img.1': (have_tools ? 'man1' : ''), > Queued, thanks. Paolo