From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning
Date: Tue, 18 Jul 2017 17:01:10 -0500 [thread overview]
Message-ID: <b27c6322-49f7-3f73-6df3-e8f4ddae9652@redhat.com> (raw)
In-Reply-To: <1500395194-21455-5-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]
On 07/18/2017 11:26 AM, Peter Maydell wrote:
> On OpenBSD the compiler warns:
> bsd-user/main.c:622:21: warning: variable 'sig' set but not used [-Wunused-but-set-variable]
>
> This is because a lot of the signal delivery code is #if-0'd
> out as unused. Reshuffle #ifdefs a bit to silence the warning.
Why not just nuke the #if 0 code instead (we can always 'git revert' it
later as a starting point for someone that wants to implement it).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-07-18 22:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 16:26 [Qemu-trivial] [PATCH for-2.10 0/4] bsd-user: silence warnings on OpenBSD Peter Maydell
2017-07-18 16:26 ` [Qemu-trivial] [PATCH for-2.10 1/4] bsd-user/mmap.c: Move __thread attribute to right place Peter Maydell
2017-07-18 16:45 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-18 16:26 ` [Qemu-trivial] [PATCH for-2.10 2/4] bsd-user/elfload.c: Fix set-but-not-used warnings Peter Maydell
2017-07-18 16:44 ` Philippe Mathieu-Daudé
2017-07-18 16:26 ` [Qemu-trivial] [PATCH for-2.10 3/4] bsd-user/bsdload.c: Remove write-only id_change variable Peter Maydell
2017-07-21 11:12 ` [Qemu-trivial] [Qemu-devel] " Thomas Huth
2017-07-21 15:25 ` Peter Maydell
2017-07-18 16:26 ` [Qemu-trivial] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning Peter Maydell
2017-07-18 22:01 ` Eric Blake [this message]
2017-07-19 8:19 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2017-07-21 11:18 ` Thomas Huth
2017-07-21 12:23 ` Eric Blake
2017-07-21 15:25 ` Peter Maydell
2017-07-18 21:29 ` [Qemu-trivial] [Qemu-devel] [PATCH for-2.10 0/4] bsd-user: silence warnings on OpenBSD no-reply
2017-07-21 10:27 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b27c6322-49f7-3f73-6df3-e8f4ddae9652@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).