From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dmOrB-0000vo-8b for mharc-qemu-trivial@gnu.org; Mon, 28 Aug 2017 14:33:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmOr8-0000uG-UI for qemu-trivial@nongnu.org; Mon, 28 Aug 2017 14:33:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmOr7-0002IV-V8 for qemu-trivial@nongnu.org; Mon, 28 Aug 2017 14:33:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmOr3-0002Et-C6; Mon, 28 Aug 2017 14:33:45 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 36B584ACB5; Mon, 28 Aug 2017 18:33:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 36B584ACB5 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jsnow@redhat.com Received: from [10.18.17.231] (dhcp-17-231.bos.redhat.com [10.18.17.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CE695C588; Mon, 28 Aug 2017 18:33:43 +0000 (UTC) To: Thomas Huth , qemu-devel@nongnu.org, qemu-trivial@nongnu.org Cc: Markus Armbruster References: <1503916557-1292-1-git-send-email-thuth@redhat.com> From: John Snow Message-ID: Date: Mon, 28 Aug 2017 14:33:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503916557-1292-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 28 Aug 2017 18:33:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests/libqtest: Use a proper error message if QTEST_QEMU_BINARY is missing X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 18:33:51 -0000 On 08/28/2017 06:35 AM, Thomas Huth wrote: > The user can currently still cause an abort() if running certain tests > (like the prom-env-test) without setting the QTEST_QEMU_BINARY first. > A similar problem has been fixed with commit 7c933ad61b8f3f51337 > already, but forgot to also take care of the qtest_get_arch() function, > so let's introduce a proper wrapper around getenv("QTEST_QEMU_BINARY") > that can be used in both locations now. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1713434 > Signed-off-by: Thomas Huth Reviewed-by: John Snow