* [PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy
@ 2023-12-24 11:43 Stefan Weil
2023-12-25 8:02 ` Michael Tokarev
2023-12-26 15:22 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2023-12-24 11:43 UTC (permalink / raw)
To: Stefan Hajnoczi, Kevin Wolf
Cc: Hanna Reitz, qemu-block, qemu-devel, qemu-trivial, Stefan Weil
Fixes: CID 1532828
Fixes: b6948ab01d ("virtio-blk: add iothread-vq-mapping parameter")
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/block/dataplane/virtio-blk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 6debd4401e..97a302cf49 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -152,7 +152,7 @@ bool virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf,
void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
{
VirtIOBlock *vblk;
- VirtIOBlkConf *conf = s->conf;
+ VirtIOBlkConf *conf;
if (!s) {
return;
@@ -160,6 +160,7 @@ void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
vblk = VIRTIO_BLK(s->vdev);
assert(!vblk->dataplane_started);
+ conf = s->conf;
if (conf->iothread_vq_mapping_list) {
IOThreadVirtQueueMappingList *node;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy
2023-12-24 11:43 [PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy Stefan Weil
@ 2023-12-25 8:02 ` Michael Tokarev
2023-12-26 15:22 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2023-12-25 8:02 UTC (permalink / raw)
To: Stefan Weil, Stefan Hajnoczi, Kevin Wolf
Cc: Hanna Reitz, qemu-block, qemu-devel, qemu-trivial
24.12.2023 14:43, Stefan Weil:
> Fixes: CID 1532828
> Fixes: b6948ab01d ("virtio-blk: add iothread-vq-mapping parameter")
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Applied to the trivial-patches tree, thank you!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy
2023-12-24 11:43 [PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy Stefan Weil
2023-12-25 8:02 ` Michael Tokarev
@ 2023-12-26 15:22 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-12-26 15:22 UTC (permalink / raw)
To: Stefan Weil, Stefan Hajnoczi, Kevin Wolf
Cc: Hanna Reitz, qemu-block, qemu-devel, qemu-trivial
On 24/12/23 12:43, Stefan Weil via wrote:
> Fixes: CID 1532828
> Fixes: b6948ab01d ("virtio-blk: add iothread-vq-mapping parameter")
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/block/dataplane/virtio-blk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-26 15:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-24 11:43 [PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy Stefan Weil
2023-12-25 8:02 ` Michael Tokarev
2023-12-26 15:22 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).