From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ez34s-0004aN-5g for mharc-qemu-trivial@gnu.org; Thu, 22 Mar 2018 12:28:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez34q-0004YX-2W for qemu-trivial@nongnu.org; Thu, 22 Mar 2018 12:28:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez34p-0002xX-3Q for qemu-trivial@nongnu.org; Thu, 22 Mar 2018 12:28:32 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46522 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ez34R-0002mR-MK; Thu, 22 Mar 2018 12:28:07 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B12834070212; Thu, 22 Mar 2018 16:28:03 +0000 (UTC) Received: from [10.10.121.135] (ovpn-121-135.rdu2.redhat.com [10.10.121.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id E24F08442D; Thu, 22 Mar 2018 16:27:52 +0000 (UTC) To: Laurent Vivier , qemu-devel@nongnu.org References: <20180322161226.29796-1-lvivier@redhat.com> Cc: Peter Crosthwaite , =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= , "Dr. David Alan Gilbert" , Paolo Bonzini , David Gibson , Kevin Wolf , Richard Henderson , qemu-arm@nongnu.org, Jason Wang , Max Reitz , Fam Zheng , qemu-trivial@nongnu.org, Alexander Graf , qemu-ppc@nongnu.org, Peter Maydell , Alberto Garcia , qemu-block@nongnu.org, Igor Mitsyanko , Yongbok Kim , "Michael S. Tsirkin" , Aurelien Jarno , Eduardo Habkost , Max Filippov , Markus Armbruster From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Thu, 22 Mar 2018 11:27:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180322161226.29796-1-lvivier@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 22 Mar 2018 16:28:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 22 Mar 2018 16:28:03 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'eblake@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 16:28:33 -0000 On 03/22/2018 11:12 AM, Laurent Vivier wrote: > I've re-run some scripts from the coccinelle directory, > and they have found some problems. > > This series fixes them. > > Laurent Vivier (4): > error: Strip trailing '\n' from error string arguments (again again) This is user-visible, so appropriate during freeze as a bug fix. It's closes to the error/qapi code that Markus normally maintains (and where I'm filling in while he is out), so I'll queue this one on my QAPI tree. > error: Remove NULL checks on error_propagate() calls > qdict: remove useless cast > Remove unnecessary variables for function return value These are cosmetic; they should be no-ops. 2 and 3 are again best through error/qapi, while 4 is more generic, but there's little reason to split up the series just because 4 is not as closely related. Unless anyone has an opinion otherwise, I'm planning to also include them in my QAPI tree for 2.12. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org