From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
qemu-devel@nongnu.org
Cc: "Aurelien Jarno" <aurelien@aurel32.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] tests/functional/mips64el: Silence issues reported by pylint
Date: Wed, 5 Nov 2025 12:33:09 +0100 [thread overview]
Message-ID: <c0e39e96-c2c6-4cf6-b614-f54a3f9c7bb8@redhat.com> (raw)
In-Reply-To: <5dfe6daf-b8d6-4371-a4a4-6cf98977349f@linaro.org>
On 04/11/2025 16.02, Philippe Mathieu-Daudé wrote:
> On 3/11/25 20:24, Thomas Huth wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> Drop unused imports, annotate imports that are not at the top, but done
>> on purpose in other locations, use f-strings where it makes sense, etc.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/functional/mips64el/test_malta.py | 15 ++++++++-------
>> tests/functional/mips64el/test_replay.py | 4 ++--
>> 2 files changed, 10 insertions(+), 9 deletions(-)
>
>
>> - def test_mips64el_malta_5KEc_cpio(self):
>> + def test_mips64el_malta_5kec_cpio(self):
>
> I don't see how helpful this warning is... Can't we disable it too?
It's the preferred Python coding style:
https://peps.python.org/pep-0008/#function-and-variable-names
Question is whether we want to follow/enforce it in QEMU or not?
> Otherwise:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks,
Thomas
prev parent reply other threads:[~2025-11-05 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 19:24 [PATCH] tests/functional/mips64el: Silence issues reported by pylint Thomas Huth
2025-11-04 15:02 ` Philippe Mathieu-Daudé
2025-11-05 11:33 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0e39e96-c2c6-4cf6-b614-f54a3f9c7bb8@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=jiaxun.yang@flygoat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).