* Re: [Qemu-trivial] [Qemu-devel] [PATCH] vhost: fix incorrect print type
[not found] ` <9bacd55b-4333-28fd-18cb-c0dbd771062c@redhat.com>
@ 2019-05-29 13:13 ` Philippe Mathieu-Daudé
2019-06-06 9:20 ` Laurent Vivier
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-29 13:13 UTC (permalink / raw)
To: Jie Wang, qemu-devel; +Cc: eric.fangyi, wu.wubin, mst, QEMU Trivial
Cc'ing qemu-trivial
On 4/30/19 10:48 AM, Philippe Mathieu-Daudé wrote:
> On 4/30/19 8:29 AM, Jie Wang wrote:
>> fix incorrect print type in vhost_virtqueue_stop
>>
>> Signed-off-by: Jie Wang <wangjie88@huawei.com>
>> ---
>> hw/virtio/vhost.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
>> index 7f61018f2a..286bb27c65 100644
>> --- a/hw/virtio/vhost.c
>> +++ b/hw/virtio/vhost.c
>> @@ -1081,7 +1081,7 @@ static void vhost_virtqueue_stop(struct vhost_dev *dev,
>>
>> r = dev->vhost_ops->vhost_get_vring_base(dev, &state);
>> if (r < 0) {
>> - VHOST_OPS_DEBUG("vhost VQ %d ring restore failed: %d", idx, r);
>> + VHOST_OPS_DEBUG("vhost VQ %u ring restore failed: %d", idx, r);
>
> 'idx' is indeed unsigned.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>> /* Connection to the backend is broken, so let's sync internal
>> * last avail idx to the device used idx.
>> */
>>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] vhost: fix incorrect print type
2019-05-29 13:13 ` [Qemu-trivial] [Qemu-devel] [PATCH] vhost: fix incorrect print type Philippe Mathieu-Daudé
@ 2019-06-06 9:20 ` Laurent Vivier
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Vivier @ 2019-06-06 9:20 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Jie Wang, qemu-devel
Cc: QEMU Trivial, mst, wu.wubin, eric.fangyi
Le 29/05/2019 à 15:13, Philippe Mathieu-Daudé a écrit :
> Cc'ing qemu-trivial
>
> On 4/30/19 10:48 AM, Philippe Mathieu-Daudé wrote:
>> On 4/30/19 8:29 AM, Jie Wang wrote:
>>> fix incorrect print type in vhost_virtqueue_stop
>>>
>>> Signed-off-by: Jie Wang <wangjie88@huawei.com>
>>> ---
>>> hw/virtio/vhost.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
>>> index 7f61018f2a..286bb27c65 100644
>>> --- a/hw/virtio/vhost.c
>>> +++ b/hw/virtio/vhost.c
>>> @@ -1081,7 +1081,7 @@ static void vhost_virtqueue_stop(struct vhost_dev *dev,
>>>
>>> r = dev->vhost_ops->vhost_get_vring_base(dev, &state);
>>> if (r < 0) {
>>> - VHOST_OPS_DEBUG("vhost VQ %d ring restore failed: %d", idx, r);
>>> + VHOST_OPS_DEBUG("vhost VQ %u ring restore failed: %d", idx, r);
>>
>> 'idx' is indeed unsigned.
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>>> /* Connection to the backend is broken, so let's sync internal
>>> * last avail idx to the device used idx.
>>> */
>>>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-06 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1556605773-42019-1-git-send-email-wangjie88@huawei.com>
[not found] ` <9bacd55b-4333-28fd-18cb-c0dbd771062c@redhat.com>
2019-05-29 13:13 ` [Qemu-trivial] [Qemu-devel] [PATCH] vhost: fix incorrect print type Philippe Mathieu-Daudé
2019-06-06 9:20 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).