From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dazBm-00071s-CS for mharc-qemu-trivial@gnu.org; Fri, 28 Jul 2017 02:55:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dazBk-0006zk-1Z for qemu-trivial@nongnu.org; Fri, 28 Jul 2017 02:55:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dazBj-0004Zr-6O for qemu-trivial@nongnu.org; Fri, 28 Jul 2017 02:55:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55218) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dazBb-0004Uf-Mx; Fri, 28 Jul 2017 02:55:47 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7354C365923; Fri, 28 Jul 2017 06:55:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7354C365923 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=thuth@redhat.com Received: from [10.36.116.117] (ovpn-116-117.ams2.redhat.com [10.36.116.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 837AA70902; Fri, 28 Jul 2017 06:55:44 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Peter Maydell Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20170728053610.15770-1-f4bug@amsat.org> <20170728053610.15770-3-f4bug@amsat.org> From: Thomas Huth Message-ID: Date: Fri, 28 Jul 2017 08:55:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170728053610.15770-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 28 Jul 2017 06:55:46 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 02/47] MAINTAINERS: add missing ARM entries X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jul 2017 06:55:57 -0000 On 28.07.2017 07:35, Philippe Mathieu-Daud=C3=A9 wrote: > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > MAINTAINERS | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 972118e70b..795f89f709 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -120,6 +120,8 @@ F: include/hw/cpu/a*mpcore.h > F: disas/arm.c > F: disas/arm-a64.cc > F: disas/libvixl/ > +F: default-configs/arm-softmmu.mak > +F: default-configs/aarch64-softmmu.mak You've added this to the TCG CPU core section, but strictly speaking these files are also used for the machine emulation in general (and also for KVM). So not sure whether this is a good fit here ... up to Peter to decide. > CRIS > M: Edgar E. Iglesias > @@ -380,6 +382,7 @@ M: Peter Maydell > L: qemu-arm@nongnu.org > S: Maintained > F: hw/char/pl011.c > +F: include/hw/char/pl011.h > F: hw/display/pl110* > F: hw/dma/pl080.c > F: hw/dma/pl330.c > @@ -402,14 +405,19 @@ F: hw/intc/arm* > F: hw/intc/gic_internal.h > F: hw/misc/a9scu.c > F: hw/misc/arm11scu.c > +F: hw/misc/arm_sysctl.c According to a comment in that file, it is about RealView/Versatile boards instead, so this is the wrong section here? > F: hw/timer/a9gtimer* > F: hw/timer/arm_* > +F: hw/timer/armv7m_systick.c How about rather removing the underscore in the previous wildcard entry? > F: include/hw/arm/arm.h > +F: include/hw/arm/armv7m*.h > F: include/hw/intc/arm* > F: include/hw/misc/a9scu.h > F: include/hw/misc/arm11scu.h > F: include/hw/timer/a9gtimer.h > F: include/hw/timer/arm_mptimer.h > +F: include/hw/timer/armv7m_systick.h > +F: tests/test-arm-mptimer.c > =20 > Exynos > M: Igor Mitsyanko >=20 Thomas