From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
qemu-trivial@nongnu.org, Fam Zheng <famz@redhat.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-trivial] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile
Date: Tue, 30 May 2017 18:34:46 +0200 [thread overview]
Message-ID: <e8fdae1c-9d3c-1059-509a-6b85000e83a9@de.ibm.com> (raw)
In-Reply-To: <149615665491.28067.17765793725374594694.stgit@bahia.lan>
On 05/30/2017 05:04 PM, Greg Kurz wrote:
> The docker-run-test-build@debian-s390x-cross target fails with:
>
> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>
> The configure script defines a STRIP makefile variable whose default
> value is ${cross_prefix}strip. Let's use it.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> pc-bios/s390-ccw/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> index 79a46b67356f..7af57dad109c 100644
> --- a/pc-bios/s390-ccw/Makefile
> +++ b/pc-bios/s390-ccw/Makefile
> @@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS)
> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>
> s390-ccw.img: s390-ccw.elf
> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>
> $(OBJECTS): Makefile
>
>
I was going to apply this, but it fails with --disable-strip like
/bin/sh: --strip-unneeded: command not found
Makefile:25: recipe for target 's390-ccw.img' failed
make[1]: *** [s390-ccw.img] Error 127
Makefile:354: recipe for target 'romsubdir-s390-ccw' failed
make: *** [romsubdir-s390-ccw] Error 2
Not yet sure whats going on.
next prev parent reply other threads:[~2017-05-30 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 15:04 [Qemu-trivial] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile Greg Kurz
2017-05-30 15:09 ` Philippe Mathieu-Daudé
2017-05-30 16:34 ` Christian Borntraeger [this message]
2017-05-30 16:56 ` [Qemu-trivial] [Qemu-devel] " Greg Kurz
2017-05-31 13:15 ` Laurent Vivier
2017-05-31 13:30 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8fdae1c-9d3c-1059-509a-6b85000e83a9@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=famz@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).