From: Thomas Huth <thuth@redhat.com>
To: "Michael Walle" <michael@walle.cc>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 16/29] lm32: use QEMU_IS_ALIGNED macro
Date: Tue, 18 Jul 2017 16:37:57 +0200 [thread overview]
Message-ID: <f8dcb381-0935-bf7a-55a7-79d24f51e1dc@redhat.com> (raw)
In-Reply-To: <501136f163a5ab92df3d839360483774@walle.cc>
On 18.07.2017 13:42, Michael Walle wrote:
> Am 2017-07-18 08:09, schrieb Philippe Mathieu-Daudé:
>> Applied using the Coccinelle semantic patch
>> scripts/coccinelle/use_osdep.cocci
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> QEMU_IS_ALIGNED() sounds like it is used to check if a memory access is
> aligned. Although it does the same, the line in question is used for
> formatted output. I'm not sure if this macro should be used here.
+1
I think we should not replace every usage of % blindly. It does really
look wrong in this case here.
Thomas
next prev parent reply other threads:[~2017-07-18 14:38 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 6:09 [Qemu-trivial] [PATCH 00/29] coccinelle script to enforce qemu/osdep.h macros usage Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 01/29] coccinelle: add a " Philippe Mathieu-Daudé
2017-07-18 15:18 ` Eric Blake
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 02/29] pci: remove superfluous parenthesis Philippe Mathieu-Daudé
2017-07-19 0:16 ` [Qemu-trivial] [Qemu-devel] " Richard Henderson
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 03/29] qemu-img: use QEMU_IS_ALIGNED macro Philippe Mathieu-Daudé
2017-07-18 15:19 ` Eric Blake
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 04/29] scsi-disk: " Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 05/29] block: " Philippe Mathieu-Daudé
2017-07-18 9:59 ` Juan Quintela
2017-07-18 15:25 ` Eric Blake
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 06/29] migration/block: " Philippe Mathieu-Daudé
2017-07-18 9:58 ` Juan Quintela
2017-07-18 11:19 ` [Qemu-trivial] [Qemu-devel] " Alex Bennée
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 07/29] ds1338: " Philippe Mathieu-Daudé
2017-07-18 10:23 ` Alastair D'Silva
2017-07-18 13:23 ` Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 08/29] ui: " Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 09/29] net: " Philippe Mathieu-Daudé
2017-07-18 17:51 ` Eric Blake
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 10/29] net/rocker: " Philippe Mathieu-Daudé
2017-07-18 17:51 ` Eric Blake
2017-07-21 16:23 ` Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 11/29] s390x/sclp: " Philippe Mathieu-Daudé
2017-07-18 9:58 ` Cornelia Huck
2017-07-18 10:03 ` Cornelia Huck
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 12/29] sm501: " Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 13/29] tcg: " Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 14/29] cris: " Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 16/29] lm32: " Philippe Mathieu-Daudé
2017-07-18 11:42 ` Michael Walle
2017-07-18 14:37 ` Thomas Huth [this message]
2017-07-21 16:29 ` [Qemu-trivial] [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 18/29] nios2: " Philippe Mathieu-Daudé
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 19/29] disas: " Philippe Mathieu-Daudé
2017-07-18 11:07 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 14:43 ` Thomas Huth
2017-07-23 14:52 ` Paolo Bonzini
2017-07-24 12:16 ` Eric Blake
2017-07-18 11:09 ` [Qemu-trivial] " Michael Tokarev
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 20/29] disas: use ARRAY_SIZE macro Philippe Mathieu-Daudé
2017-07-18 6:49 ` David Gibson
2017-07-18 10:55 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 21/29] qga: " Philippe Mathieu-Daudé
2017-07-18 11:29 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 22/29] vmsvga: " Philippe Mathieu-Daudé
2017-07-18 11:28 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 6:09 ` [Qemu-trivial] [PATCH 23/29] async: " Philippe Mathieu-Daudé
2017-07-18 10:54 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 6:10 ` [Qemu-trivial] [PATCH 24/29] tests/acpi: " Philippe Mathieu-Daudé
2017-07-18 6:10 ` [Qemu-trivial] [PATCH 25/29] libqos: " Philippe Mathieu-Daudé
2017-07-18 11:00 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 11:58 ` [Qemu-trivial] " Laurent Vivier
2017-07-18 13:36 ` Philippe Mathieu-Daudé
2017-07-18 6:10 ` [Qemu-trivial] [PATCH 26/29] tests/tcg: " Philippe Mathieu-Daudé
2017-07-18 10:56 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 11:16 ` Alex Bennée
2017-07-18 11:24 ` Marc-André Lureau
2017-07-18 13:52 ` Alex Bennée
2017-07-18 13:41 ` Philippe Mathieu-Daudé
2017-07-18 6:10 ` [Qemu-trivial] [PATCH 27/29] tests/hbitmap: " Philippe Mathieu-Daudé
2017-07-18 10:52 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 15:36 ` John Snow
2017-07-18 6:10 ` [Qemu-trivial] [PATCH 28/29] tests/qapi: use QEMU_IS_ALIGNED macro Philippe Mathieu-Daudé
2017-07-18 10:53 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
2017-07-18 6:10 ` [Qemu-trivial] [PATCH 29/29] tests/qapi: use ARRAY_SIZE macro Philippe Mathieu-Daudé
2017-07-18 10:52 ` [Qemu-trivial] [Qemu-devel] " Marc-André Lureau
[not found] ` <20170718061005.29518-16-f4bug@amsat.org>
2017-07-18 11:08 ` [Qemu-trivial] [Qemu-devel] [PATCH 15/29] microblaze: use QEMU_IS_ALIGNED macro Marc-André Lureau
2017-07-18 14:46 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8dcb381-0935-bf7a-55a7-79d24f51e1dc@redhat.com \
--to=thuth@redhat.com \
--cc=f4bug@amsat.org \
--cc=michael@walle.cc \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).