* [Qemu-trivial] [Qemu-devel] [PATCH] arm cpu state loading fix
@ 2011-10-17 10:53 Dmitry Koshelev
2011-10-17 11:19 ` Peter Maydell
2011-10-17 11:50 ` [Qemu-trivial] " Juan Quintela
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Koshelev @ 2011-10-17 10:53 UTC (permalink / raw)
To: qemu-devel, paul; +Cc: qemu-trivial
Floating registers loading fix.
Signed-off-by: Dmitry Koshelev <karaghiozis@gmail.com>
---
target-arm/machine.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-arm/machine.c b/target-arm/machine.c
index 3925d3a..73d82c9 100644
--- a/target-arm/machine.c
+++ b/target-arm/machine.c
@@ -175,7 +175,7 @@ int cpu_load(QEMUFile *f, void *opaque, int version_id)
env->vfp.vec_stride = qemu_get_be32(f);
if (arm_feature(env, ARM_FEATURE_VFP3)) {
- for (i = 0; i < 16; i++) {
+ for (i = 16; i < 32; i++) {
CPU_DoubleU u;
u.l.upper = qemu_get_be32(f);
u.l.lower = qemu_get_be32(f);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] arm cpu state loading fix
2011-10-17 10:53 [Qemu-trivial] [Qemu-devel] [PATCH] arm cpu state loading fix Dmitry Koshelev
@ 2011-10-17 11:19 ` Peter Maydell
2011-10-17 11:50 ` [Qemu-trivial] " Juan Quintela
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2011-10-17 11:19 UTC (permalink / raw)
To: Dmitry Koshelev; +Cc: qemu-trivial, qemu-devel, paul
On 17 October 2011 11:53, Dmitry Koshelev <karaghiozis@gmail.com> wrote:
> Floating registers loading fix.
>
> Signed-off-by: Dmitry Koshelev <karaghiozis@gmail.com>
> ---
> target-arm/machine.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/machine.c b/target-arm/machine.c
> index 3925d3a..73d82c9 100644
> --- a/target-arm/machine.c
> +++ b/target-arm/machine.c
> @@ -175,7 +175,7 @@ int cpu_load(QEMUFile *f, void *opaque, int version_id)
> env->vfp.vec_stride = qemu_get_be32(f);
>
> if (arm_feature(env, ARM_FEATURE_VFP3)) {
> - for (i = 0; i < 16; i++) {
> + for (i = 16; i < 32; i++) {
> CPU_DoubleU u;
> u.l.upper = qemu_get_be32(f);
> u.l.lower = qemu_get_be32(f);
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] arm cpu state loading fix
2011-10-17 10:53 [Qemu-trivial] [Qemu-devel] [PATCH] arm cpu state loading fix Dmitry Koshelev
2011-10-17 11:19 ` Peter Maydell
@ 2011-10-17 11:50 ` Juan Quintela
2011-10-17 11:57 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Juan Quintela @ 2011-10-17 11:50 UTC (permalink / raw)
To: Dmitry Koshelev; +Cc: qemu-trivial, qemu-devel, paul
Dmitry Koshelev <karaghiozis@gmail.com> wrote:
> Floating registers loading fix.
>
> Signed-off-by: Dmitry Koshelev <karaghiozis@gmail.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
/me really wonders if arm migration has ever worked :-(
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] arm cpu state loading fix
2011-10-17 11:50 ` [Qemu-trivial] " Juan Quintela
@ 2011-10-17 11:57 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2011-10-17 11:57 UTC (permalink / raw)
To: quintela; +Cc: qemu-trivial, Dmitry Koshelev, qemu-devel, paul
On 17 October 2011 12:50, Juan Quintela <quintela@redhat.com> wrote:
> Dmitry Koshelev <karaghiozis@gmail.com> wrote:
>> Floating registers loading fix.
>>
>> Signed-off-by: Dmitry Koshelev <karaghiozis@gmail.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> /me really wonders if arm migration has ever worked :-(
I've used save/restore successfully on versatilepb models
before, but only for debug, not for serious work (which
would be why I didn't hit this bug -- the test case I was
working on was probably integer only code); and in order
to get that to work I had to fix a lot of devices. There
are still some ARM devboard device models which are missing
save/restore support.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-17 11:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-17 10:53 [Qemu-trivial] [Qemu-devel] [PATCH] arm cpu state loading fix Dmitry Koshelev
2011-10-17 11:19 ` Peter Maydell
2011-10-17 11:50 ` [Qemu-trivial] " Juan Quintela
2011-10-17 11:57 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).