From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org
Subject: [RFA] A-MPDU EOF bit
Date: Fri, 26 Jan 2018 11:50:42 +0100 [thread overview]
Message-ID: <1516963842.2189.27.camel@sipsolutions.net> (raw)
Hi all,
As previously mentioned, here's my RFA for the EOF bit in the A-MPDU
field.
For HE in particular, we need to be able to capture the EOF bit in an
A-MPDU, but it also applies in VHT where single frames are really A-
MPDUs with just a single frame inside.
The change to make is the following:
| **0x0010** | delimiter CRC error |
| **0x0020** | delimiter CRC value known: the delimiter CRC value field is valid |
-| **0xffc0** | reserved |
+| **0x0040** | EOF value |
+| **0x0080** | EOF value known |
+| **0xff00** | reserved |
I have a patch to implement it in a generator here:
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git/commit/?id=55269b3861b4fbe21fdc6d7392cbe9c5bef98374
(I'll follow up with a driver patch, we have it but not pushed out yet)
Richard has a change for wireshark here:
https://code.wireshark.org/review/#/c/25472/
Hereby starting the 3-week discussion period :-)
Thanks,
johannes
next reply other threads:[~2018-01-26 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 10:50 Johannes Berg [this message]
[not found] ` <1516963842.2189.27.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-01-30 8:28 ` [RFA] A-MPDU EOF bit Johannes Berg
2018-02-20 9:29 ` [ADOPTION] " Johannes Berg
[not found] ` <1519118967.16723.23.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-06-18 13:59 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516963842.2189.27.camel@sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox