From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [RFC] 0-length PPDU reporting Date: Fri, 29 Jun 2018 12:49:26 +0200 Message-ID: <1530269366.3481.80.camel@sipsolutions.net> References: <1529332670.3490.50.camel@sipsolutions.net> <00986C20-9443-40FC-9A7E-DE636A743951@superduper.net> <1529349637.3092.8.camel@sipsolutions.net> <3028EC8F-6CFD-4F52-8349-D49B1F37AC22@alum.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: radiotap-owner-sUITvd46vNxg9hUCZPvPmw@public.gmane.org List-Unsubscribe: To: Guy Harris Cc: Simon Barber , radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org List-Id: radiotap@radiotap.org On Tue, 2018-06-19 at 15:50 -0700, Guy Harris wrote: > On Jun 19, 2018, at 2:20 PM, Guy Harris wrote: > > > On Jun 18, 2018, at 12:20 PM, Johannes Berg wrote: > > > > > A wireshark patch should be pretty simple, just don't call through to > > > the 802.11 dissector? > > > > Yes, although if it has radio information you should call through to > > the "802.11 radio" dissector (so that it shows the radio information > > in a pseudo-header-independent format) and pass along information to > > let it know that *it* shouldn't call through to the 802.11 frame > > dissector. > > Tcpdump would also need to be changed not to call ieee802_11_print() > at the end of ieee802_11_radio_print() in print-802_11.c - just return > "len" for 0-length PPDUs. Yes, both good points. Thanks! johannes