public inbox for radiotap@archiver.kernel.org
 help / color / mirror / Atom feed
From: Gerald Combs <gerald-IZ8446WsY0/dtAWm4Da02A@public.gmane.org>
To: Pavel Roskin <proski-mXXj517/zsQ@public.gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	radiotap <radiotap-rN9S6JXhQ+WXmMXjJBpWqg@public.gmane.org>
Subject: Re: use of radiotap bit 14?
Date: Fri, 31 Aug 2007 09:50:44 -0700	[thread overview]
Message-ID: <46D846E4.20103@wireshark.org> (raw)
In-Reply-To: <1188571628.24684.7.camel@dv>

Pavel Roskin wrote:
> On Fri, 2007-08-31 at 00:16 +0200, Johannes Berg wrote:
>> Our radiotap header in Linux defines bit 14 as
>> IEEE80211_RADIOTAP_RX_FLAGS; however running wireshark on it tells me
>> that this bit means "FCS in header". Does anybody know which use is
>> correct, if any?
> 
> As far as I know, "FCS in header" is a FreeBSD thing, which came to
> Linux in MadWifi.  "Rx flags" comes from Linux Libertas driver.
> 
> The standard uses the later:
> http://netbsd.gw.com/cgi-bin/man-cgi?ieee80211_radiotap+9+NetBSD-current
> 
> MadWifi has removed the non-standard use of bit 14.  Now it's time to
> fix wireshark.

The problem is a little more widespread than that.  Packet-radiotap.h in 
the Wireshark sources has the following comments:

/*
  * AAAAAAAAAAAAAAAAAAAAAAAAAARGH.
  *
  * The current FreeBSD ieee80211_radiotap.h has IEEE80211_RADIOTAP_XCHANNEL
  * as 14.
  *
  * The current NetBSD ieee80211_radiotap.h has IEEE80211_RADIOTAP_RX_FLAGS
  * as 14.
  *
  * The current OpenBSD ieee80211_radiotap.h has IEEE80211_RADIOTAP_FCS as
  * 14.
  *
  * NetBSD and OpenBSD also differ on what comes *after* 14.
  *
  * They all use the same DLT_ value for "802.11+radiotap".
  *
  * This is all wonderfully appreciated by those of us who write code to
  * read files containing packets with radiotap headers.  I will see if
  * I can apply a little cluebat-fu here.
  */

and

     /* XXX - IEEE80211_RADIOTAP_FCS is used by MadWifi and AirPcap, but
      * was never officially assigned. */

I'll open a ticket on Wireshark's Bugzilla so we (Wireshark) don't lose 
track of this before the next release.  I'll talk to the guys here 
(CACE) about fixing AirPcap as well.

An earlier email from David Young discussed placing the Radiotap 
documentation in a more "official" location -- I think this would help 
immensely.  For a developer starting from scratch, it's not immediately 
obvious where the canonical Radiotap specification is and it's very easy 
to get started down the wrong path.  For example, if NetBSD Radiotap 
header and man page show up in Google's rankings for "radiotap" and 
"radiotap specification", they're pretty far down the list.

  parent reply	other threads:[~2007-08-31 16:50 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-30 22:16 use of radiotap bit 14? Johannes Berg
     [not found] ` <1188512214.7585.3.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-08-31 14:47   ` Pavel Roskin
2007-08-31 16:23     ` Sam Leffler
     [not found]       ` <46D84073.3090709-zZXckVAlHaQAvxtiuMwx3w@public.gmane.org>
2007-08-31 16:33         ` Sam Leffler
2007-08-31 16:50     ` Gerald Combs [this message]
     [not found]       ` <46D846E4.20103-IZ8446WsY0/dtAWm4Da02A@public.gmane.org>
2007-08-31 21:57         ` Johannes Berg
     [not found]           ` <1188597475.7585.46.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-08-31 22:17             ` Pavel Roskin
2007-09-12 17:17             ` David Young
     [not found]               ` <20070912171755.GA17887-eZ+MEZF6i8Dc+919tysfdA@public.gmane.org>
2007-09-12 19:21                 ` Gerald Combs
2007-09-13  7:18                 ` Johannes Berg
     [not found]                   ` <1189667921.6161.86.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-11-26 16:58                     ` Johannes Berg
     [not found]                       ` <1196096301.4149.309.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-11-26 18:13                         ` David Young
     [not found]                           ` <20071126181329.GA3568-eZ+MEZF6i8Dc+919tysfdA@public.gmane.org>
2007-11-27 13:21                             ` Johannes Berg
2007-09-12 18:06   ` David Young
     [not found]     ` <20070912180619.GB17887-eZ+MEZF6i8Dc+919tysfdA@public.gmane.org>
2007-09-12 19:03       ` Pavel Roskin
2007-09-13 18:06         ` David Young
     [not found]           ` <20070913180618.GK17887-eZ+MEZF6i8Dc+919tysfdA@public.gmane.org>
2007-09-13 18:15             ` Guy Harris
2007-09-13  7:29       ` Johannes Berg
     [not found]         ` <1189668582.6161.91.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-10-07 23:55           ` David Young
     [not found]             ` <20071007235551.GN6429-eZ+MEZF6i8Dc+919tysfdA@public.gmane.org>
2007-10-08  9:45               ` Johannes Berg
     [not found]                 ` <1191836708.4063.17.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-06-19 16:13                   ` Johannes Berg
2007-12-11 23:09               ` Johannes Berg
2007-12-12 17:27               ` Johannes Berg
2008-06-19 18:10               ` Johannes Berg
     [not found]                 ` <1213899026.8967.56.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-06-19 18:41                   ` Johannes Berg
2008-06-19 17:44   ` Johannes Berg
     [not found]     ` <1213897499.8967.46.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-06-19 17:59       ` Johannes Berg
     [not found]         ` <1213898387.8967.54.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-06-19 18:28           ` Gerald Combs
     [not found]             ` <485AA531.4010408-IZ8446WsY0/dtAWm4Da02A@public.gmane.org>
2008-06-19 18:34               ` Guy Harris
     [not found]                 ` <485AA6C3.8090303-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2008-06-19 18:37                   ` Johannes Berg
2008-06-19 20:05           ` Johannes Berg
2008-06-19 18:13       ` Pavel Roskin
2008-06-19 18:18         ` Johannes Berg
     [not found]           ` <1213899529.8967.62.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-06-19 18:39             ` Pavel Roskin
2008-06-19 18:43               ` Johannes Berg
2008-06-19 18:56       ` David Young
     [not found]         ` <20080619185646.GA17738-eZ+MEZF6i8Dc+919tysfdA@public.gmane.org>
2008-06-19 19:10           ` Johannes Berg
     [not found]             ` <1213902633.8967.84.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-06-19 19:33               ` Guy Harris
     [not found]                 ` <485AB49B.4080403-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2008-06-19 19:59                   ` Johannes Berg
2008-06-19 19:39               ` David Young
     [not found]                 ` <20080619193958.GB17738-eZ+MEZF6i8Dc+919tysfdA@public.gmane.org>
2008-06-19 19:51                   ` Guy Harris
     [not found]                     ` <485AB8B0.7060606-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2008-06-19 20:06                       ` Loris Degioanni
     [not found]                         ` <485ABC4A.4060801-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-06-19 20:17                           ` Guy Harris
2008-06-19 20:25                           ` Johannes Berg
2008-07-01 16:35                       ` use of radiotap bit 14? [mostly 11n] Sam Leffler
2008-06-19 20:06                   ` use of radiotap bit 14? Johannes Berg
2008-06-19 22:33           ` Scott Raynel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D846E4.20103@wireshark.org \
    --to=gerald-iz8446wsy0/dtawm4da02a@public.gmane.org \
    --cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
    --cc=proski-mXXj517/zsQ@public.gmane.org \
    --cc=radiotap-rN9S6JXhQ+WXmMXjJBpWqg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox