From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joel Fernandes <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
jiangshanlai@gmail.com, dipankar@in.ibm.com,
mathieu.desnoyers@efficios.com, josh@joshtriplett.org,
luto@kernel.org, byungchul.park@lge.com
Subject: Re: [PATCH tip/core/rcu 06/19] rcu: Add warning to detect half-interrupts
Date: Wed, 13 Mar 2019 11:07:30 -0700 [thread overview]
Message-ID: <20190313180730.GU13351@linux.ibm.com> (raw)
In-Reply-To: <20190313125125.1a1fb2f3@gandalf.local.home>
On Wed, Mar 13, 2019 at 12:51:25PM -0400, Steven Rostedt wrote:
> On Wed, 13 Mar 2019 08:51:55 -0700
> "Paul E. McKenney" <paulmck@linux.ibm.com> wrote:
>
> > Does this mean that there is a better approach that Joel's suggestion?
> > I believe he would end up with something like this:
> >
> > WARN_ON_ONCE(IS_ENABLED(CONFIG_PROVE_RCU) && !in_irq());
> >
> > It would be nice if there is something like this:
> >
> > lockdep_assert_in_irq_handler();
> >
> > But I haven't seen this. (Not that I have looked particularly hard for
> > such a thing, mind you!)
>
> That would be trivial to implement:
>
> #define lockdep_assert_in_irq() do {
> WARN_ON(debug_locks && !current->hardirq_context);
> } while (0)
Looks good to me!
Joel, does this work for you? I could be wrong, but I suspect that Steve
is suggesting that you incorporate the above into your eventual patch. ;-)
Thanx, Paul
next prev parent reply other threads:[~2019-03-13 18:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180829222021.GA29944@linux.vnet.ibm.com>
[not found] ` <20180829222047.319-6-paulmck@linux.vnet.ibm.com>
2019-03-11 13:39 ` [PATCH tip/core/rcu 06/19] rcu: Add warning to detect half-interrupts Joel Fernandes
2019-03-11 22:29 ` Paul E. McKenney
2019-03-12 15:05 ` Joel Fernandes
2019-03-12 15:20 ` Paul E. McKenney
2019-03-13 15:09 ` Joel Fernandes
2019-03-13 15:27 ` Steven Rostedt
2019-03-13 15:51 ` Paul E. McKenney
2019-03-13 16:51 ` Steven Rostedt
2019-03-13 18:07 ` Paul E. McKenney [this message]
2019-03-14 12:31 ` Joel Fernandes
2019-03-14 13:36 ` Steven Rostedt
2019-03-14 13:37 ` Steven Rostedt
2019-03-14 21:27 ` Joel Fernandes
2019-03-15 7:31 ` Byungchul Park
2019-03-15 7:44 ` Byungchul Park
2019-03-15 13:46 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313180730.GU13351@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=byungchul.park@lge.com \
--cc=dipankar@in.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox