From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Philippe Mazenauer <philippe.mazenauer@outlook.de>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
"rcu@vger.kernel.org" <rcu@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: Remove unused variable
Date: Fri, 17 May 2019 04:57:34 -0700 [thread overview]
Message-ID: <20190517115734.GJ28207@linux.ibm.com> (raw)
In-Reply-To: <20190517105111.GW4319@dell>
On Fri, May 17, 2019 at 11:51:11AM +0100, Lee Jones wrote:
> On Fri, 17 May 2019, Philippe Mazenauer wrote:
>
> > Variable 'rdp' is set but not used in synchronize_rcu_expidited(). The
> > macro per_cpu_ptr() used to set the value of 'rdp' has no side effect.
> >
> > ../kernel/rcu/tree_exp.h:768:19: warning: variable ‘rdp’ set but not used [-Wunused-but-set-variable]
> > struct rcu_data *rdp;
> > ^~~
> >
> > Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
> > ---
> > kernel/rcu/tree_exp.h | 2 --
> > 1 file changed, 2 deletions(-)
>
> Looks reasonable:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
Good eyes!
However, Jiang Biao beat you to it. Please see commmit a18e1552af94
("rcu: Remove unused rdp local from synchronize_rcu_expedited()") in -rcu:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git branch
"dev".
Thanx, Paul
prev parent reply other threads:[~2019-05-17 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 10:41 [PATCH] rcu: Remove unused variable Philippe Mazenauer
2019-05-17 10:51 ` Lee Jones
2019-05-17 11:57 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517115734.GJ28207@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=philippe.mazenauer@outlook.de \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox