From: Joel Fernandes <joel@joelfernandes.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: paulmck@kernel.org, rcu@vger.kernel.org
Subject: Re: [bug report] refperf: Dynamically allocate experiment-summary output buffer
Date: Fri, 29 May 2020 13:55:42 -0400 [thread overview]
Message-ID: <20200529175542.GA197424@google.com> (raw)
In-Reply-To: <20200529094829.GA1302781@mwanda>
On Fri, May 29, 2020 at 12:48:29PM +0300, Dan Carpenter wrote:
> Hello Paul E. McKenney,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 54c0ed208976: "refperf: Dynamically allocate
> experiment-summary output buffer" from May 25, 2020, leads to the
> following Smatch complaint:
>
> kernel/rcu/refperf.c:395 main_func()
> error: we previously assumed 'buf' could be null (see line 352)
>
> kernel/rcu/refperf.c
> 351 buf = kzalloc(64 + nruns * 32, GFP_KERNEL);
> 352 if (!result_avg || !buf) {
> ^^^^
> Check for NULL
Makes sense. Looks like Paul already fixed it so should be good.
Thanks!
prev parent reply other threads:[~2020-05-29 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 9:48 [bug report] refperf: Dynamically allocate experiment-summary output buffer Dan Carpenter
2020-05-29 17:55 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529175542.GA197424@google.com \
--to=joel@joelfernandes.org \
--cc=dan.carpenter@oracle.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox