From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30A63C388F9 for ; Thu, 5 Nov 2020 03:48:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6FF42072E for ; Thu, 5 Nov 2020 03:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604548112; bh=HqU1hZ9it/Jd6nRb4F6S3FiwocUkTFhhalGcS4V1/zY=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=U4q86jND3pOMS2ONL4ODGbUUmT10anHjWizQbXhqadamQwipIaacDAPRn1w66y9E4 7JWJ7rHcR23iSyl7iZ4Kt+rr3LHBjDxuospx8KiqDEtFgAL3g90SyaAVfvEOCNZ4iL rsLFVUUiZ6hzSPbDT2OByOpNGLU38RTHBoDFxnns= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388678AbgKEDsb (ORCPT ); Wed, 4 Nov 2020 22:48:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:41488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388708AbgKEDsZ (ORCPT ); Wed, 4 Nov 2020 22:48:25 -0500 Received: from paulmck-ThinkPad-P72.home (50-39-104-11.bvtn.or.frontiernet.net [50.39.104.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6292E2072C; Thu, 5 Nov 2020 03:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604548104; bh=HqU1hZ9it/Jd6nRb4F6S3FiwocUkTFhhalGcS4V1/zY=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=l5vHcDYIz8Xl/sAHZlJakwO7Klh9NVyJHo2gtioWBLNcz86MQlabqOBPaIbFRyskj fGiIr1Dh/t2oksqjzJdWoj3NAxj/4TaD5nXz+8uATo3Abmlbm+mYAyAQQsmgQo2Aja E/XRfri5SaC9tSoYlyTUkRE8l1g1wjF+sYfTuFog= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 006623522683; Wed, 4 Nov 2020 19:48:23 -0800 (PST) Date: Wed, 4 Nov 2020 19:48:23 -0800 From: "Paul E. McKenney" To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Josh Triplett , Lai Jiangshan , Marco Elver , Mathieu Desnoyers , rcu@vger.kernel.org, Steven Rostedt , "Uladzislau Rezki (Sony)" , fweisbec@gmail.com, neeraj.iitr10@gmail.com Subject: Re: [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include Message-ID: <20201105034823.GK3249@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20201103142603.1302207-1-joel@joelfernandes.org> <20201103142603.1302207-6-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103142603.1302207-6-joel@joelfernandes.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org On Tue, Nov 03, 2020 at 09:26:01AM -0500, Joel Fernandes (Google) wrote: > Signed-off-by: Joel Fernandes (Google) This one looks fine, but depends on the earlier "rcu/segcblist: Add counters to segcblist datastructure" patch, which also changes the list of #include directives for this file. It manages to avoid conflicting with "rcu/trace: Add tracing for how segcb list changes", despite this one also changing the #include directives. I am testing it just out of curiosity, but it might make more sense to fold this one into "rcu/segcblist: Add counters to segcblist datastructure". Thanx, Paul > --- > kernel/rcu/rcu_segcblist.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c > index 2a03949d0b82..e9e72d72f7a6 100644 > --- a/kernel/rcu/rcu_segcblist.c > +++ b/kernel/rcu/rcu_segcblist.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > > #include "rcu_segcblist.h" > -- > 2.29.1.341.ge80a0c044ae-goog >