From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH rcu 1/2] docs: Add documentation for rude and trace RCU flavors
Date: Wed, 20 Apr 2022 12:19:06 -0400 [thread overview]
Message-ID: <20220420121906.13752d3e@gandalf.local.home> (raw)
In-Reply-To: <20220420161319.GD4285@paulmck-ThinkPad-P17-Gen-1>
On Wed, 20 Apr 2022 09:13:19 -0700
"Paul E. McKenney" <paulmck@kernel.org> wrote:
> > > +The tasks-rude-RCU API is also reader-marking-free and thus quite compact,
> > > +consisting of call_rcu_tasks_rude(), synchronize_rcu_tasks_rude(),
> > > +and rcu_barrier_tasks_rude().
> >
> > Are we going to be able to get rid of the "rude" version once we have all
> > tracing in a RCU visible section?
>
> You tell me! ;-)
>
> If there are no longer any users, I would be happy to get rid of it.
> As of v5.18-rc1, the only user is ftrace.
>
> > > +
> > > +Tasks Trace RCU
> > > +~~~~~~~~~~~~~~~
> > > +
> > > +Some forms of tracing need to sleep in readers, but cannot tolerate
> > > +SRCU's read-side overhead, which includes a full memory barrier in both
> > > +srcu_read_lock() and srcu_read_unlock(). This need is handled by a
> > > +Tasks Trace RCU that uses scheduler locking and IPIs to synchronize with
> > > +readers. Real-time systems that cannot tolerate IPIs may build their
> > > +kernels with ``CONFIG_TASKS_TRACE_RCU_READ_MB=y``, which avoids the IPIs at
> > > +the expense of adding full memory barriers to the read-side primitives.
> >
> > If NOHZ_FULL is enabled, is there a way to also be able to have this full
> > mb on RT removed as well?
> >
Hmm, if we no longer need the rude version due to noinstr, if then we need
to use something that adds full memory barriers at *every function call*
then I rather keep the rude version.
-- Steve
next prev parent reply other threads:[~2022-04-20 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 22:50 [PATCH rcu 0/2] Documentation updates for v5.19 Paul E. McKenney
2022-04-18 22:50 ` [PATCH rcu 1/2] docs: Add documentation for rude and trace RCU flavors Paul E. McKenney
2022-04-20 15:32 ` Steven Rostedt
2022-04-20 16:13 ` Paul E. McKenney
2022-04-20 16:16 ` Steven Rostedt
2022-04-20 16:19 ` Steven Rostedt [this message]
2022-04-20 16:48 ` Paul E. McKenney
2022-04-20 18:02 ` Steven Rostedt
2022-04-20 18:37 ` Paul E. McKenney
2022-04-20 18:43 ` Steven Rostedt
2022-04-20 19:22 ` Paul E. McKenney
2022-04-18 22:50 ` [PATCH rcu 2/2] docs: Update RCU cross-references as suggested in doc-guide Paul E. McKenney
2022-04-19 7:08 ` [PATCH rcu 0/2] Documentation updates for v5.19 Bagas Sanjaya
2022-04-19 14:23 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420121906.13752d3e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox