From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
rostedt@goodmis.org, Zhao Mengmeng <zhaomengmeng@kylinos.cn>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH rcu 01/10] rcu: Use hlist_nulls_next_rcu() in hlist_nulls_add_tail_rcu()
Date: Wed, 4 Jan 2023 16:22:56 -0800 [thread overview]
Message-ID: <20230105002305.1768591-1-paulmck@kernel.org> (raw)
In-Reply-To: <20230105002257.GA1768487@paulmck-ThinkPad-P17-Gen-1>
From: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
In commit 8dbd76e79a16 ("tcp/dccp: fix possible race
__inet_lookup_established()"), function hlist_nulls_add_tail_rcu() was
added back, but the local variable *last* is of type hlist_nulls_node,
so use hlist_nulls_next_rcu() instead of hlist_next_rcu().
Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
include/linux/rculist_nulls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h
index d8afdb8784c1c..ba4c00dd8005a 100644
--- a/include/linux/rculist_nulls.h
+++ b/include/linux/rculist_nulls.h
@@ -139,7 +139,7 @@ static inline void hlist_nulls_add_tail_rcu(struct hlist_nulls_node *n,
if (last) {
n->next = last->next;
n->pprev = &last->next;
- rcu_assign_pointer(hlist_next_rcu(last), n);
+ rcu_assign_pointer(hlist_nulls_next_rcu(last), n);
} else {
hlist_nulls_add_head_rcu(n, h);
}
--
2.31.1.189.g2e36527f23
next prev parent reply other threads:[~2023-01-05 0:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 0:22 [PATCH rcu 0/10] Miscellaneous fixes for v6.3 Paul E. McKenney
2023-01-05 0:22 ` Paul E. McKenney [this message]
2023-01-05 0:22 ` [PATCH rcu 02/10] rcu: Consolidate initialization and CPU-hotplug code Paul E. McKenney
2023-01-05 0:22 ` [PATCH rcu 03/10] rcu: Throttle callback invocation based on number of ready callbacks Paul E. McKenney
2023-01-05 0:22 ` [PATCH rcu 04/10] rcu: Upgrade header comment for poll_state_synchronize_rcu() Paul E. McKenney
2023-01-05 0:23 ` [PATCH rcu 05/10] rcu: Make RCU_LOCKDEP_WARN() avoid early lockdep checks Paul E. McKenney
2023-01-05 0:23 ` [PATCH rcu 06/10] rcu: Suppress smp_processor_id() complaint in synchronize_rcu_expedited_wait() Paul E. McKenney
2023-01-05 0:23 ` [PATCH rcu 07/10] rcu: Make rcu_blocking_is_gp() stop early-boot might_sleep() Paul E. McKenney
2023-01-05 0:23 ` [PATCH rcu 08/10] rcu: Test synchronous RCU grace periods at the end of rcu_init() Paul E. McKenney
2023-01-05 0:23 ` [PATCH rcu 09/10] rcu: Allow expedited RCU CPU stall warnings to dump task stacks Paul E. McKenney
2023-01-05 0:23 ` [PATCH rcu 10/10] rcu: Remove redundant call to rcu_boost_kthread_setaffinity() Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105002305.1768591-1-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zhaomengmeng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox