From: Zqiang <qiang1.zhang@intel.com>
To: urezki@gmail.com, paulmck@kernel.org, frederic@kernel.org,
joel@joelfernandes.org, qiang1.zhang@intel.com
Cc: qiang.zhang1211@gmail.com, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3] rcu/kvfree: Prevents cache growing when the backoff_page_cache_fill is set
Date: Sat, 8 Apr 2023 22:25:17 +0800 [thread overview]
Message-ID: <20230408142517.800549-1-qiang1.zhang@intel.com> (raw)
Currently, in kfree_rcu_shrink_scan(), the drain_page_cache() is
executed before kfree_rcu_monitor() to drain page cache, if the bnode
structure's->gp_snap has done, the kvfree_rcu_bulk() will fill the
page cache again in kfree_rcu_monitor(), this commit add a check
for krcp structure's->backoff_page_cache_fill in put_cached_bnode(),
if the krcp structure's->backoff_page_cache_fill is set, prevent page
cache growing and disable allocated page in fill_page_cache_func().
Signed-off-by: Zqiang <qiang1.zhang@intel.com>
---
kernel/rcu/tree.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index cc34d13be181..9d9d3772cc45 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -2908,6 +2908,8 @@ static inline bool
put_cached_bnode(struct kfree_rcu_cpu *krcp,
struct kvfree_rcu_bulk_data *bnode)
{
+ if (atomic_read(&krcp->backoff_page_cache_fill))
+ return false;
// Check the limit.
if (krcp->nr_bkv_objs >= rcu_min_cached_objs)
return false;
@@ -3221,7 +3223,7 @@ static void fill_page_cache_func(struct work_struct *work)
int i;
nr_pages = atomic_read(&krcp->backoff_page_cache_fill) ?
- 1 : rcu_min_cached_objs;
+ 0 : rcu_min_cached_objs;
for (i = 0; i < nr_pages; i++) {
bnode = (struct kvfree_rcu_bulk_data *)
--
2.32.0
next reply other threads:[~2023-04-08 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 14:25 Zqiang [this message]
2023-04-10 23:34 ` [PATCH v3] rcu/kvfree: Prevents cache growing when the backoff_page_cache_fill is set Paul E. McKenney
2023-04-11 4:04 ` Zhang, Qiang1
2023-04-11 14:25 ` Uladzislau Rezki
2023-04-11 14:42 ` Zhang, Qiang1
2023-04-11 14:58 ` Uladzislau Rezki
2023-04-11 15:09 ` Zhang, Qiang1
2023-04-11 15:14 ` Uladzislau Rezki
2023-04-11 16:42 ` Paul E. McKenney
2023-04-11 17:10 ` Uladzislau Rezki
2023-04-12 9:14 ` Zhang, Qiang1
2023-04-12 12:32 ` Uladzislau Rezki
2023-04-12 14:21 ` Zhang, Qiang1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230408142517.800549-1-qiang1.zhang@intel.com \
--to=qiang1.zhang@intel.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox