Linux RCU subsystem development
 help / color / mirror / Atom feed
From: Levi Yun <ppbuk5246@gmail.com>
To: paulmck@kernel.org, frederic@kernel.org,
	quic_neeraju@quicinc.com, joel@joelfernandes.org,
	osh@joshtriplett.org, boqun.feng@gmail.com, rostedt@goodmis.org,
	mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
	qiang.zhang1211@gmail.com
Cc: Levi Yun <ppbuk5246@gmail.com>,
	rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] rcu: remove unnecessary check cpu_no_qs.norm on rcu_report_qs_rdp
Date: Fri, 21 Jul 2023 13:15:33 +0100	[thread overview]
Message-ID: <20230721121534.44328-1-ppbuk5246@gmail.com> (raw)

Wherever rcu_report_qs_rdp is called, cpu_no_qs.norm value is false.
Therefore, Remove unnecessary check in rcu_report_qs_rdp.

Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
---
 kernel/rcu/tree.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 1449cb69a0e0..d840596e9903 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1962,8 +1962,7 @@ rcu_report_qs_rdp(struct rcu_data *rdp)
 	WARN_ON_ONCE(rdp->cpu != smp_processor_id());
 	rnp = rdp->mynode;
 	raw_spin_lock_irqsave_rcu_node(rnp, flags);
-	if (rdp->cpu_no_qs.b.norm || rdp->gp_seq != rnp->gp_seq ||
-	    rdp->gpwrap) {
+	if (rdp->gp_seq != rnp->gp_seq || rdp->gpwrap) {

 		/*
 		 * The grace period in which this quiescent state was
--
2.37.2

             reply	other threads:[~2023-07-21 12:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 12:15 Levi Yun [this message]
2023-07-21 21:43 ` [PATCH] rcu: remove unnecessary check cpu_no_qs.norm on rcu_report_qs_rdp Paul E. McKenney
2023-07-22  9:23   ` Yun Levi
2023-07-22 17:40     ` Paul E. McKenney
2023-07-22 20:14       ` Yun Levi
2023-07-22 22:39         ` Paul E. McKenney
2023-07-23  6:23           ` Yun Levi
2023-07-23 17:24             ` Paul E. McKenney
2023-07-24  3:21             ` Z qiang
2023-07-24  5:28               ` Yun Levi
2023-07-24  6:48                 ` Z qiang
2023-07-24  8:59                   ` Yun Levi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721121534.44328-1-ppbuk5246@gmail.com \
    --to=ppbuk5246@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=osh@joshtriplett.org \
    --cc=paulmck@kernel.org \
    --cc=qiang.zhang1211@gmail.com \
    --cc=quic_neeraju@quicinc.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox