Linux RCU subsystem development
 help / color / mirror / Atom feed
From: Joel Fernandes <joel@joelfernandes.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>, rcu <rcu@vger.kernel.org>
Subject: Re: [BUG] NOHZ tick-stop error: local softirq work is pending
Date: Sun, 10 Sep 2023 23:02:09 +0000	[thread overview]
Message-ID: <20230910230209.GA1832306@google.com> (raw)
In-Reply-To: <ZP4mRzlA4uCs6-Tk@localhost.localdomain>

On Sun, Sep 10, 2023 at 10:25:43PM +0200, Frederic Weisbecker wrote:
> Le Sun, Sep 10, 2023 at 03:21:33AM -0700, Paul E. McKenney a écrit :
> > On Sat, Sep 09, 2023 at 10:28:36PM -0400, Joel Fernandes wrote:
> > > Hi Paul, Frederic, ever since this recent patch got merged into all
> > > recent stables:
> > > https://lore.kernel.org/all/20230818200757.1808398-1-paul.gortmaker@windriver.com/
> > >  ..
> > > 
> > > .. I am seeing this happen a lot now causing rcutorture failures:
> > > "NOHZ tick-stop error: local softirq work is pending"
> > > 
> > > It looks like the "tick-stop error" as local_bh_blocked always returns
> > > false on !PREEMPT_RT, so that patch itself seems correct.
> > > 
> > > However, it appears the string in console-badness.sh is different:
> > > 
> > > console-badness.sh:grep -v 'NOHZ tick-stop error: Non-RCU local
> > > softirq work is pending, handler'
> > > 
> > > So the string in the script needs an update?
> > 
> > Looks like it, though I believe that there is a fix in the offing,
> > at which point that "grep -v" should just be removed.  Depending on
> > timing, of course.
> 
> Yep I have a pending fix for that, will post soonish. The grep will still
> make sense afterward though.

I was wondering why the grep -v will still make sense if the pending fix
works. Or is there another legitimate reason for the string to appear?

Either way, looking forward to the patch!

thanks,

 - Joel


  parent reply	other threads:[~2023-09-10 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-10  2:28 [BUG] NOHZ tick-stop error: local softirq work is pending Joel Fernandes
2023-09-10 10:21 ` Paul E. McKenney
2023-09-10 20:25   ` Frederic Weisbecker
2023-09-10 21:48     ` Paul E. McKenney
2023-09-10 23:02     ` Joel Fernandes [this message]
2023-09-11 21:23       ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230910230209.GA1832306@google.com \
    --to=joel@joelfernandes.org \
    --cc=frederic@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox