* [PATCH] srcu/tiny: Remove preempt_disable/enable() in srcu_gp_start_if_needed()
@ 2025-09-08 0:31 Zqiang
2025-09-08 1:29 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Zqiang @ 2025-09-08 0:31 UTC (permalink / raw)
To: paulmck, frederic, neeraj.upadhyay, joelagnelf, boqun.feng,
urezki
Cc: qiang.zhang, rcu, linux-kernel
Currently, the srcu_gp_start_if_needed() is always be invoked in
preempt disable's critical section, this commit therefore remove
redundant preempt_disable/enable() in srcu_gp_start_if_needed().
Fixes: 65b4a59557f6 ("srcu: Make Tiny SRCU explicitly disable preemption")
Signed-off-by: Zqiang <qiang.zhang@linux.dev>
---
kernel/rcu/srcutiny.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/rcu/srcutiny.c b/kernel/rcu/srcutiny.c
index b52ec45698e8..417bd0e4457c 100644
--- a/kernel/rcu/srcutiny.c
+++ b/kernel/rcu/srcutiny.c
@@ -181,10 +181,8 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
{
unsigned long cookie;
- preempt_disable(); // Needed for PREEMPT_LAZY
cookie = get_state_synchronize_srcu(ssp);
if (ULONG_CMP_GE(READ_ONCE(ssp->srcu_idx_max), cookie)) {
- preempt_enable();
return;
}
WRITE_ONCE(ssp->srcu_idx_max, cookie);
@@ -194,7 +192,6 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
else if (list_empty(&ssp->srcu_work.entry))
list_add(&ssp->srcu_work.entry, &srcu_boot_list);
}
- preempt_enable();
}
/*
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] srcu/tiny: Remove preempt_disable/enable() in srcu_gp_start_if_needed()
2025-09-08 0:31 [PATCH] srcu/tiny: Remove preempt_disable/enable() in srcu_gp_start_if_needed() Zqiang
@ 2025-09-08 1:29 ` Paul E. McKenney
2025-09-08 13:19 ` Zqiang
0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2025-09-08 1:29 UTC (permalink / raw)
To: Zqiang
Cc: frederic, neeraj.upadhyay, joelagnelf, boqun.feng, urezki, rcu,
linux-kernel
On Mon, Sep 08, 2025 at 08:31:55AM +0800, Zqiang wrote:
> Currently, the srcu_gp_start_if_needed() is always be invoked in
> preempt disable's critical section, this commit therefore remove
> redundant preempt_disable/enable() in srcu_gp_start_if_needed().
>
> Fixes: 65b4a59557f6 ("srcu: Make Tiny SRCU explicitly disable preemption")
> Signed-off-by: Zqiang <qiang.zhang@linux.dev>
Looks good, but what would be a good way to make this code defend itself
against being invoked from someplace else that did have preemption
enabled? Especially given that the Tree SRCU version of this function
does get invoked with preemption enabled?
Thanx, Paul
> ---
> kernel/rcu/srcutiny.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/rcu/srcutiny.c b/kernel/rcu/srcutiny.c
> index b52ec45698e8..417bd0e4457c 100644
> --- a/kernel/rcu/srcutiny.c
> +++ b/kernel/rcu/srcutiny.c
> @@ -181,10 +181,8 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
> {
> unsigned long cookie;
>
> - preempt_disable(); // Needed for PREEMPT_LAZY
> cookie = get_state_synchronize_srcu(ssp);
> if (ULONG_CMP_GE(READ_ONCE(ssp->srcu_idx_max), cookie)) {
> - preempt_enable();
> return;
> }
> WRITE_ONCE(ssp->srcu_idx_max, cookie);
> @@ -194,7 +192,6 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
> else if (list_empty(&ssp->srcu_work.entry))
> list_add(&ssp->srcu_work.entry, &srcu_boot_list);
> }
> - preempt_enable();
> }
>
> /*
> --
> 2.48.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] srcu/tiny: Remove preempt_disable/enable() in srcu_gp_start_if_needed()
2025-09-08 1:29 ` Paul E. McKenney
@ 2025-09-08 13:19 ` Zqiang
2025-09-09 0:23 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Zqiang @ 2025-09-08 13:19 UTC (permalink / raw)
To: paulmck
Cc: frederic, neeraj.upadhyay, joelagnelf, boqun.feng, urezki, rcu,
linux-kernel
>
> On Mon, Sep 08, 2025 at 08:31:55AM +0800, Zqiang wrote:
>
> >
> > Currently, the srcu_gp_start_if_needed() is always be invoked in
> > preempt disable's critical section, this commit therefore remove
> > redundant preempt_disable/enable() in srcu_gp_start_if_needed().
> >
> > Fixes: 65b4a59557f6 ("srcu: Make Tiny SRCU explicitly disable preemption")
> > Signed-off-by: Zqiang <qiang.zhang@linux.dev>
> >
> Looks good, but what would be a good way to make this code defend itself
> against being invoked from someplace else that did have preemption
> enabled? Especially given that the Tree SRCU version of this function
> does get invoked with preemption enabled?
ok, maybe we can add lockdep_assert_preemption_disabled() in
the srcu_gp_start_if_needed() ?
Thanks
Zqiang
>
> Thanx, Paul
>
> >
> > ---
> > kernel/rcu/srcutiny.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/kernel/rcu/srcutiny.c b/kernel/rcu/srcutiny.c
> > index b52ec45698e8..417bd0e4457c 100644
> > --- a/kernel/rcu/srcutiny.c
> > +++ b/kernel/rcu/srcutiny.c
> > @@ -181,10 +181,8 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
> > {
> > unsigned long cookie;
> >
> > - preempt_disable(); // Needed for PREEMPT_LAZY
> > cookie = get_state_synchronize_srcu(ssp);
> > if (ULONG_CMP_GE(READ_ONCE(ssp->srcu_idx_max), cookie)) {
> > - preempt_enable();
> > return;
> > }
> > WRITE_ONCE(ssp->srcu_idx_max, cookie);
> > @@ -194,7 +192,6 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
> > else if (list_empty(&ssp->srcu_work.entry))
> > list_add(&ssp->srcu_work.entry, &srcu_boot_list);
> > }
> > - preempt_enable();
> > }
> >
> > /*
> > --
> > 2.48.1
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] srcu/tiny: Remove preempt_disable/enable() in srcu_gp_start_if_needed()
2025-09-08 13:19 ` Zqiang
@ 2025-09-09 0:23 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2025-09-09 0:23 UTC (permalink / raw)
To: Zqiang
Cc: frederic, neeraj.upadhyay, joelagnelf, boqun.feng, urezki, rcu,
linux-kernel
On Mon, Sep 08, 2025 at 01:19:44PM +0000, Zqiang wrote:
> >
> > On Mon, Sep 08, 2025 at 08:31:55AM +0800, Zqiang wrote:
> >
> > >
> > > Currently, the srcu_gp_start_if_needed() is always be invoked in
> > > preempt disable's critical section, this commit therefore remove
> > > redundant preempt_disable/enable() in srcu_gp_start_if_needed().
> > >
> > > Fixes: 65b4a59557f6 ("srcu: Make Tiny SRCU explicitly disable preemption")
> > > Signed-off-by: Zqiang <qiang.zhang@linux.dev>
> > >
> > Looks good, but what would be a good way to make this code defend itself
> > against being invoked from someplace else that did have preemption
> > enabled? Especially given that the Tree SRCU version of this function
> > does get invoked with preemption enabled?
>
> ok, maybe we can add lockdep_assert_preemption_disabled() in
> the srcu_gp_start_if_needed() ?
That sounds like a good idea to me!
Thanx, Paul
> Thanks
> Zqiang
>
>
> >
> > Thanx, Paul
> >
> > >
> > > ---
> > > kernel/rcu/srcutiny.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/kernel/rcu/srcutiny.c b/kernel/rcu/srcutiny.c
> > > index b52ec45698e8..417bd0e4457c 100644
> > > --- a/kernel/rcu/srcutiny.c
> > > +++ b/kernel/rcu/srcutiny.c
> > > @@ -181,10 +181,8 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
> > > {
> > > unsigned long cookie;
> > >
> > > - preempt_disable(); // Needed for PREEMPT_LAZY
> > > cookie = get_state_synchronize_srcu(ssp);
> > > if (ULONG_CMP_GE(READ_ONCE(ssp->srcu_idx_max), cookie)) {
> > > - preempt_enable();
> > > return;
> > > }
> > > WRITE_ONCE(ssp->srcu_idx_max, cookie);
> > > @@ -194,7 +192,6 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp)
> > > else if (list_empty(&ssp->srcu_work.entry))
> > > list_add(&ssp->srcu_work.entry, &srcu_boot_list);
> > > }
> > > - preempt_enable();
> > > }
> > >
> > > /*
> > > --
> > > 2.48.1
> > >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-09 0:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-08 0:31 [PATCH] srcu/tiny: Remove preempt_disable/enable() in srcu_gp_start_if_needed() Zqiang
2025-09-08 1:29 ` Paul E. McKenney
2025-09-08 13:19 ` Zqiang
2025-09-09 0:23 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).