From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB55132038B for ; Thu, 11 Sep 2025 12:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757595134; cv=none; b=mSA0B3QJ+RTAIOD4Jt1nxmON7e0Y0ENnz0NnJc7MrY+GymVDLPzCgca3IE3SWrAAxcmqMoiGRXG3iEWNhfpcvlQvupKLtAg2BmZ3KPZmpv3NDeZ7ud5csnwfBGYHcR36MsG2OlWnB4CP3pdzQj8gmriPAY33C5kOLGVyzx7blMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757595134; c=relaxed/simple; bh=5p/zS4lP41e2pD4xGW0+TuQeawK0/VWCW7E1bV8uYPw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WG+jB/lahkDdJki0IGTxXn8pZ2hR5XHBcle2lDmCMzxoHnULpszcbwzw3U7TW+RL5WJyUSnt0lWODi+XUw5UjyEVVBuVrm32xKKJojeMusSPK6llt1lpGq+eB9mQfULblei3TqAwCwdKWUnw5CrLBGuSML0ncyha5btW3E02BNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hPX2kgov; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hPX2kgov" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1757595120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2Jen2glJvsL1zeTu2Lyjg5IcVv3okUbisL9PfS0foS8=; b=hPX2kgovC0cfVHUI5LjvqZ4sjj9un+Vv3JgFzMQFqAnazDElQzAFM7qjkar4hIPA6WE/I4 WvTu8j1OCFHIne85f5oRIkZqGypjYPfNctYsCpSJaC7u8NKtOZvZauja6KAwtUcgFrI/pQ iNVPWs7U/LlguRf9FtRkjbw4IrOKFoE= From: Zqiang To: paulmck@kernel.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, joelagnelf@nvidia.com, boqun.feng@gmail.com, urezki@gmail.com Cc: qiang.zhang@linux.dev, rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] srcu/tiny: Remove preempt_disable/enable() in srcu_gp_start_if_needed() Date: Thu, 11 Sep 2025 20:51:55 +0800 Message-ID: <20250911125155.680960-1-qiang.zhang@linux.dev> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Currently, the srcu_gp_start_if_needed() is always be invoked in preempt disable's critical section, this commit therefore remove redundant preempt_disable/enable() in srcu_gp_start_if_needed() and adds a call to lockdep_assert_preemption_disabled() in order to enable lockdep to diagnose mistaken invocations of this function from preempts-enabled code. Fixes: 65b4a59557f6 ("srcu: Make Tiny SRCU explicitly disable preemption") Signed-off-by: Zqiang Signed-off-by: Paul E. McKenney --- kernel/rcu/srcutiny.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/rcu/srcutiny.c b/kernel/rcu/srcutiny.c index b52ec45698e8..3450c3751ef7 100644 --- a/kernel/rcu/srcutiny.c +++ b/kernel/rcu/srcutiny.c @@ -181,10 +181,9 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp) { unsigned long cookie; - preempt_disable(); // Needed for PREEMPT_LAZY + lockdep_assert_preemption_disabled(); // Needed for PREEMPT_LAZY cookie = get_state_synchronize_srcu(ssp); if (ULONG_CMP_GE(READ_ONCE(ssp->srcu_idx_max), cookie)) { - preempt_enable(); return; } WRITE_ONCE(ssp->srcu_idx_max, cookie); @@ -194,7 +193,6 @@ static void srcu_gp_start_if_needed(struct srcu_struct *ssp) else if (list_empty(&ssp->srcu_work.entry)) list_add(&ssp->srcu_work.entry, &srcu_boot_list); } - preempt_enable(); } /* -- 2.48.1