From: Borislav Petkov <bp@alien8.de>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, rostedt@goodmis.org
Subject: Re: [PATCH v4 1/2] rcu: Make expedited RCU CPU stall warnings detect stall-end races
Date: Wed, 31 Dec 2025 18:13:17 +0100 [thread overview]
Message-ID: <20251231171317.GBaVVZreLiknrb8zWT@fat_crate.local> (raw)
In-Reply-To: <20251229191616.693898-1-paulmck@kernel.org>
On Mon, Dec 29, 2025 at 11:16:15AM -0800, Paul E. McKenney wrote:
> If an expedited RCU CPU stall ends just at the stall-warning timeout,
> the current code will print an expedited stall-warning message, but one
> that doesn't identify any CPUs or tasks causing the stall. This is most
> likely to happen for short-timeout stalls, for example, the 20-millisecond
> timeouts that are sometimes used for small embedded devices. Needless to
> say, these semi-empty stall-warning messages can be rather confusing.
>
> One option would be to suppress the stall-warning message entirely in
> this case, but the near-miss information can be quite valuable.
>
> This commit therefore detects this race condition and emits a "INFO:
s/This commit therefore detects this/Detect this/
> Expedited stall ended before state dump start" message to clarify matters.
>
> Reported-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> ---
> kernel/rcu/tree_exp.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
But yeah, makes sense.
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2025-12-31 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 19:16 [PATCH 0/2] Miscellaneous fixes for post-v4.19 Paul E. McKenney
2025-12-29 19:16 ` [PATCH v4 1/2] rcu: Make expedited RCU CPU stall warnings detect stall-end races Paul E. McKenney
2025-12-31 17:13 ` Borislav Petkov [this message]
2025-12-29 19:16 ` [PATCH v4 2/2] rcutorture: Correctly compute probability to invoke ->exp_current() Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251231171317.GBaVVZreLiknrb8zWT@fat_crate.local \
--to=bp@alien8.de \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox