From: Donglin Peng <dolinux.peng@gmail.com>
To: paulmck@kernel.org
Cc: frederic@kernel.org, neeraj.upadhyay@kernel.org,
joelagnelf@nvidia.com, qiang.zhang@linux.dev,
rostedt@goodmis.org, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org,
Donglin Peng <pengdonglin@xiaomi.com>
Subject: [PATCH] rcu: Align stall warning 'idle=' output with documentation
Date: Sun, 4 Jan 2026 16:10:27 +0800 [thread overview]
Message-ID: <20260104081027.189234-1-dolinux.peng@gmail.com> (raw)
From: Donglin Peng <pengdonglin@xiaomi.com>
The RCU stall warning message includes an "idle=" field to indicate
the dyntick-idle state of a CPU. According to Documentation/RCU/stallwarn.rst,
the hexadecimal number before the first '/' represents the low-order 16
bits of the dynticks counter. An even value denotes that the CPU is in
dyntick-idle mode, while an odd value indicates otherwise.
This was accurate until commit 171476775d32 ("context_tracking: Convert state to atomic_t"),
which merged the context tracking state and the dynticks counter into a
single atomic value. Consequently, the value printed in the stall warning
no longer directly corresponds to the documented dynticks counter bits.
To restore consistency between the code's output and the documentation,
right-shift the merged atomic state value to extract and display the
correct low-order bits of the dynticks counter.
Fixes: 171476775d32 ("context_tracking: Convert state to atomic_t")
Signed-off-by: Donglin Peng <pengdonglin@xiaomi.com>
---
kernel/rcu/tree_stall.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
index b67532cb8770..d25cc826d77a 100644
--- a/kernel/rcu/tree_stall.h
+++ b/kernel/rcu/tree_stall.h
@@ -555,7 +555,7 @@ static void print_cpu_stall_info(int cpu)
rdp->rcu_iw_pending ? (int)min(delta, 9UL) + '0' :
"!."[!delta],
ticks_value, ticks_title,
- ct_rcu_watching_cpu(cpu) & 0xffff,
+ (ct_rcu_watching_cpu(cpu) >> ilog2(CT_RCU_WATCHING)) & 0xffff,
ct_nesting_cpu(cpu), ct_nmi_nesting_cpu(cpu),
rdp->softirq_snap, kstat_softirqs_cpu(RCU_SOFTIRQ, cpu),
data_race(rcu_state.n_force_qs) - rcu_state.n_force_qs_gpstart,
--
2.34.1
next reply other threads:[~2026-01-04 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 8:10 Donglin Peng [this message]
2026-01-04 19:45 ` [PATCH] rcu: Align stall warning 'idle=' output with documentation Joel Fernandes
2026-01-05 0:26 ` Zqiang
2026-01-05 0:34 ` Joel Fernandes
2026-01-05 1:31 ` Donglin Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260104081027.189234-1-dolinux.peng@gmail.com \
--to=dolinux.peng@gmail.com \
--cc=frederic@kernel.org \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=pengdonglin@xiaomi.com \
--cc=qiang.zhang@linux.dev \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox