From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3316A4A92CB for ; Fri, 4 Sep 2026 14:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788531269; cv=none; b=K/Rh2wmDYGRDwq+22M/fZSyX8M/ChWU424IiNMgkKe/qGXtVEuIRbBXV8CJZLn+Jry64dql6gk74vFIo8T4O/+Jz1DJ6DsWpRazB1DLfwJl+1tLeiZDBajA9Lo3I02GB++rWW7+P37aOEIPPvrVepvcLHTL6AWBJpaMpjiNTxJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788531269; c=relaxed/simple; bh=Nwh6qKR0V+XnjPWwHnDPQggNun+470bR9FEfgGFIKDs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ttFYjjxYIzlBolT1eq2tmb/2uHtEwWVHKLKQlnBCIP3K6p+eYEML6ymvGfHibtQBl0461lNK6SkiqLYoox5Gajoog4Wn19aUVKsg9baj7mGpQh+u8TN5MrwRY+euAeU74mSRZQwYcl4ZWpNdB44L+gnHU/YKfwnScF+EUSTtI1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ojA3+U2v; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ojA3+U2v" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso9056665e9.1 for ; Fri, 04 Sep 2026 07:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788531266; x=1789136066; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Ci5sK1VA/AFzZLFsaPwTu74VZ2hcdCO7IieHuFxzFO8=; b=ojA3+U2vtBobsb0saxAsmVJOOvZ0tinQJcBN0YktONA64T/b7CefZwY4MdgDa3kyNp KzMbJ4/+bOvLJEC4Flqfd+1YI4qeKtorHab+rkbQhmODA70xCc/l6t18wBuwQtpblH8X wkS426Jyz17mqX9LXKqWcOcfSLScgA4dm94tRJmHdLZq2lnD0L9wZR5v0M91tqZVPG3w f4F0FcwaRnSsWTHUAJU7cL7l9fRjqH0JovlEL+S+6LPn8dFBG0ozl/jzUg0H7B13huK/ 8HdhJUNidMa7dSKcyMZqg3OY7b1tUIirVnJn0AmNvP7imn4jz3Z/KBb8u5MY0l+eTSVo gGiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788531266; x=1789136066; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Ci5sK1VA/AFzZLFsaPwTu74VZ2hcdCO7IieHuFxzFO8=; b=h8Hv4vCnETwLO7oc2c0QA+FHt75Wu1rN937rL+xgY4WivIXBdqzK4XEWxpzd08yKVo fQFGNgx1JcKvQhKH066s/NNkAFhZJHuGOyZwklKR4Htm8ZzV/nDsuFNcAaCCJVfyaotQ Vay9NZasiTlnVT/x/L9R2NnYM1ngXqDyUFzm10aKlF4FPGwelH5WB9uKHMJ/FJe60VZJ e/titxpt5VGE+bcUZe9ggid+wFF01kiYkRLghRM5/FlDGH/BaHbjzplC154IDlUd2gtK Zr5+Y6V6puA1uwz1Y05jYi6CylCJqILQfBGV7r8esZkp1ykHfh9q1c0VVjIh7x/GQBM1 FAMQ== X-Forwarded-Encrypted: i=1; AKwUvBx2rL2FmyLPC430CogZjOlQQclojOEgmwhmPXYf+RlDE/GvXzWi7o5mAkQzCy//RMzhN/U=@vger.kernel.org X-Gm-Message-State: AFuF++l1hEwYP+UmOIhDvcFZLG60YUjLG27NUfZbbEH48e1BUSo0ACwg 1G4sS5Msl39xzsChQtX4wUtpTBjhPluOTPuPXSGp1x2/HlsQtYSn8KvZ X-Gm-Gg: AYBFou3hlXwDEcvNUcDhuN+ems8svwTkdqfuMutrQWGcZBbKO3n4p0fld7FXA1KSQut ETdAD1GHTvVuT+vYhtJRPISrapr3uQtd/wZOiKknC/by3d7YtvqMwtCzbImtQYmdDO9TjYaqgp5 sKj84zdhN7VdVVFnNzJ3dax35yqRDpgKKajn7+NOQfZdA57eG4xwtMO+yCBrxwn7eTT0c0D8/hr U9DFpJq8q977OFugiRIWRnSLSlR4GsORYIt4hP+l5f+VlKSYAlVsbrpSRjJSHELvMloFb+BY5lJ j8f84YKnCVBIAYVDLe0vtX3Sv8TdMFproF7HCv02aKOGqdnnZ6KOzpCKYrLFFB5fav4+LOM4Lmk y7XaG6mqEv6Q2oxZ77haXwtFXgkRk7iPtmr2ZsIXcg0EquZ6mCMQZVfWjjeoLEWRkggd5NZhhVa nAweKIN/D0GA+UdtQoBTpQIriDpPTb/3AB6bTUj278JNs+KXLAju7kXUs0oZm6BLv3fL5egtl+J 8ZGC3f2LT8L8A== X-Received: by 2002:a05:600c:138e:b0:49c:d818:8771 with SMTP id 5b1f17b1804b1-49cf8240ba5mr60011755e9.7.1788531265797; Fri, 04 Sep 2026 07:14:25 -0700 (PDT) Received: from localhost (ip87-106-108-193.pbiaas.com. [87.106.108.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d00031c95sm263125e9.11.2026.09.04.07.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 07:14:25 -0700 (PDT) Date: Fri, 4 Sep 2026 16:14:09 +0200 From: =?iso-8859-1?Q?G=FCnther?= Noack To: Ye Liu Cc: Thomas Gleixner , Peter Zijlstra , "Rafael J. Wysocki" , Andrew Morton , Ingo Molnar , Will Deacon , Boqun Feng , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Juri Lelli , Vincent Guittot , Steven Rostedt , Masami Hiramatsu , Josh Poimboeuf , Ye Liu , Pavel Machek , Lance Yang , Petr Mladek , Waiman Long , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Mark Rutland , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rcu@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] kernel: convert process/thread iterators to for_each_*_rcu Message-ID: <20260904.84b04948b1fc@gnoack.org> References: <20260904083001.553587-1-ye.liu@linux.dev> <20260904083001.553587-6-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260904083001.553587-6-ye.liu@linux.dev> On Fri, Sep 04, 2026 at 04:29:57PM +0800, Ye Liu wrote: > diff --git a/kernel/hung_task.c b/kernel/hung_task.c > index 6fcc94ce4ca9..76871f78497f 100644 > --- a/kernel/hung_task.c > +++ b/kernel/hung_task.c > @@ -337,9 +336,7 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout) > hung_task_info(t, timeout, this_round_count); > } > } > - unlock: > - rcu_read_unlock(); > - > +unlock: > if (!this_round_count) > return; The label name "unlock" is misleading now. There is no further unlock happening after it any more. –Günther