Linux RCU subsystem development
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
	rcu@vger.kernel.org, Josh Triplett <josh@joshtriplett.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Boqun Feng <boqun@kernel.org>,
	Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH] rcutorture: Ignore KBUILD_OUTPUT in kvm.sh
Date: Sun, 18 Oct 2026 20:23:44 -0400	[thread overview]
Message-ID: <20261019002344.GA532276@joelbox> (raw)
In-Reply-To: <d3d15a05-149c-4027-9e97-6adfb4659be0@paulmck-laptop>

On Fri, Oct 16, 2026 at 09:50:32AM -0700, Paul E. McKenney wrote:
> On Fri, Oct 16, 2026 at 04:22:03PM +0100, Puranjay Mohan wrote:
> > On Fri, Oct 16, 2026 at 4:12 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> > >
> > > On Fri, Oct 16, 2026 at 03:26:56AM -0700, Puranjay Mohan wrote:
> > > > kvm.sh builds the kernel in the source tree, and kvm-build.sh and
> > > > configinit.sh expect .config and the build products to land there.
> > > > With KBUILD_OUTPUT set in the environment, make instead writes them to
> > > > that directory and fails with "The source tree is not clean" or, worse,
> > > > clobbers an unrelated build.  Unset it so kvm.sh works from such shells.
> > > >
> > > > Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
> > >
> > > Good point!
> > >
> > > Should it (non-fatally) complain if KBUILD_OUTPUT is set in order to avoid
> > > silently surprising any users expecting build products to go elsewhere?
> > 
> > I guess I am the only one!! :p
> 
> Well, the only one who has complained thus far.  ;-)
> 
> > If you think we should do it I will send v2.
> 
> Please!
> 
> The other alternative would be to make these scripts correctly handle
> KBUILD_OUTPUT.  Which is probably the "right" thing to do, but might
> or might not be a reasonable thing to do.

It may be risky if a new script is introduced that does not support
KBUILD_OUTPUT then, I think the above suggestions to warn and ignore make
sense.

I also feel kvm.sh is not a 'normal kernel build', so I think maybe
respecting KBUILD_OUTPUT is not strictly needed.

FWIW, I typically setup multiple worktrees for torture testing independent of
my main source repo so I end up not having this issue as I do all my testing
in-tree.

thanks,

Joel Fernandes


  reply	other threads:[~2026-10-19  0:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 10:26 [PATCH] rcutorture: Ignore KBUILD_OUTPUT in kvm.sh Puranjay Mohan
2026-10-16 15:11 ` Paul E. McKenney
2026-10-16 15:22   ` Puranjay Mohan
2026-10-16 16:50     ` Paul E. McKenney
2026-10-19  0:23       ` Joel Fernandes [this message]
2026-10-16 17:41 ` Bradley Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019002344.GA532276@joelbox \
    --to=joelagnelf@nvidia.com \
    --cc=boqun@kernel.org \
    --cc=frederic@kernel.org \
    --cc=josh@joshtriplett.org \
    --cc=paulmck@kernel.org \
    --cc=puranjay12@gmail.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox