Linux RCU subsystem development
 help / color / mirror / Atom feed
From: Boqun Feng <boqun.feng@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: rcu@vger.kernel.org
Subject: Re: Testing of shared RCU branching
Date: Tue, 25 Feb 2025 08:08:53 -0800	[thread overview]
Message-ID: <Z73rFVTHr-etZ8SE@Mac.home> (raw)
In-Reply-To: <c5bd6873-6e29-4f44-9c40-fbdffc6d1165@paulmck-laptop>

On Tue, Feb 25, 2025 at 07:58:01AM -0800, Paul E. McKenney wrote:
> Hello, Boqun,
> 
> I have run overnight tests on your earlier branches here:
> 
> ccb986e8b69f ("MAINTAINERS: Update Joel's email address")
> 
> These passed other than a KCSAN complaint involving
> rcu_preempt_deferred_qs_handler() and rcu_read_unlock_special().
> This looks like the plain C-language writes to ->defer_qs_iw_pending.
> 
> My guess is that this is low probability, despite having happened twice,
> and that it happens when rcu_read_unlock_special() is interrupted,
> resulting in rcu_preempt_deferred_qs_handler() being invoked as an
> IRQ-work handler.  Keeping in mind that RCU runs KCSAN so as to locate
> data races between task and handler on the same CPU.
> 
> Thoughts?
> 

Do you have a KCSAN of this? Also this is not a regression, right?
Meaning you probably have seen this before? Anyway, it should be an easy
fix (just using READ_ONCE() and WRITE_ONCE()). I can send the fix out
and put it in.

Regards,
Boqun

> 							Thanx, Paul

  reply	other threads:[~2025-02-25 16:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 15:58 Testing of shared RCU branching Paul E. McKenney
2025-02-25 16:08 ` Boqun Feng [this message]
2025-02-25 16:11   ` Boqun Feng
2025-02-25 17:54     ` Paul E. McKenney
2025-02-25 21:20       ` Joel Fernandes
2025-02-25 21:53         ` Paul E. McKenney
2025-02-25 22:04           ` Joel Fernandes
2025-02-25 23:45             ` Paul E. McKenney
2025-02-26  0:12               ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z73rFVTHr-etZ8SE@Mac.home \
    --to=boqun.feng@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox