From: Uladzislau Rezki <urezki@gmail.com>
To: Breno Leitao <leitao@debian.org>
Cc: Boqun Feng <boqun.feng@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
aeh@meta.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, edumazet@google.com, jhs@mojatatu.com,
kernel-team@meta.com, Erik Lundgren <elundgren@meta.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Uladzislau Rezki <urezki@gmail.com>,
rcu@vger.kernel.org
Subject: Re: [RFC PATCH 0/8] Introduce simple hazard pointers for lockdep
Date: Wed, 16 Apr 2025 17:04:31 +0200 [thread overview]
Message-ID: <Z__G_8VNrgUpfpuk@pc636> (raw)
In-Reply-To: <Z/+7LMnQqtV+mnJ+@gmail.com>
On Wed, Apr 16, 2025 at 07:14:04AM -0700, Breno Leitao wrote:
> Hi Boqun,
>
> On Sun, Apr 13, 2025 at 11:00:47PM -0700, Boqun Feng wrote:
>
> > Overall it looks promising to me, but I would like to see how it
> > performs in the environment of Breno. Also as Paul always reminds me:
> > buggy code usually run faster, so please take a look in case I'm missing
> > something ;-) Thanks!
>
> Thanks for the patchset. I've confirmed that the wins are large on my
> environment, but, at the same magnitute of synchronize_rcu_expedited().
>
> Here are the numbers I got:
>
> 6.15-rc1 (upstream)
> # time /usr/sbin/tc qdisc replace dev eth0 root handle 0x1234: mq
> real 0m3.986s
> user 0m0.001s
> sys 0m0.093s
>
> Your patchset on top of 6.15-rc1
> # time /usr/sbin/tc qdisc replace dev eth0 root handle 0x1234: mq
> real 0m0.072s
> user 0m0.001s
> sys 0m0.070s
>
>
> My original proposal of using synchronize_rcu_expedited()[1]
> # time /usr/sbin/tc qdisc replace dev eth0 root handle 0x1234: mq
> real 0m0.074s
> user 0m0.001s
> sys 0m0.061s
>
> Link: https://lore.kernel.org/all/20250321-lockdep-v1-1-78b732d195fb@debian.org/ [1]
>
Could you please also do the test of fist scenario with a regular
synchronize_rcu() but switch to its faster variant:
echo 1 > /sys/module/rcutree/parameters/rcu_normal_wake_from_gp
and run the test. If you have a time.
Thank you!
--
Vlad Rezki
next prev parent reply other threads:[~2025-04-16 15:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 6:00 [RFC PATCH 0/8] Introduce simple hazard pointers for lockdep Boqun Feng
2025-04-14 6:00 ` [RFC PATCH 1/8] Introduce simple hazard pointers Boqun Feng
2025-07-11 0:36 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 2/8] shazptr: Add refscale test Boqun Feng
2025-07-11 0:41 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 3/8] shazptr: Add refscale test for wildcard Boqun Feng
2025-07-11 0:42 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 4/8] shazptr: Avoid synchronize_shaptr() busy waiting Boqun Feng
2025-07-11 0:56 ` Paul E. McKenney
2025-07-11 2:29 ` Boqun Feng
2025-04-14 6:00 ` [RFC PATCH 5/8] shazptr: Allow skip self scan in synchronize_shaptr() Boqun Feng
2025-07-11 0:58 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 6/8] rcuscale: Allow rcu_scale_ops::get_gp_seq to be NULL Boqun Feng
2025-07-11 1:00 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 7/8] rcuscale: Add tests for simple hazard pointers Boqun Feng
2025-07-11 1:03 ` Paul E. McKenney
2025-04-14 6:00 ` [RFC PATCH 8/8] locking/lockdep: Use shazptr to protect the key hashlist Boqun Feng
2025-07-11 1:04 ` Paul E. McKenney
2025-04-16 14:14 ` [RFC PATCH 0/8] Introduce simple hazard pointers for lockdep Breno Leitao
2025-04-16 15:04 ` Uladzislau Rezki [this message]
2025-04-16 18:33 ` Breno Leitao
2025-04-17 8:22 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z__G_8VNrgUpfpuk@pc636 \
--to=urezki@gmail.com \
--cc=aeh@meta.com \
--cc=boqun.feng@gmail.com \
--cc=edumazet@google.com \
--cc=elundgren@meta.com \
--cc=frederic@kernel.org \
--cc=jhs@mojatatu.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).