Linux RCU subsystem development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Joel Fernandes <joelagnelf@nvidia.com>
Cc: rcu@vger.kernel.org
Subject: [bug report] rcutorture: Perform more frequent testing of ->gpwrap
Date: Wed, 23 Apr 2025 10:17:16 +0300	[thread overview]
Message-ID: <aAiT_KWYN-gP-2MN@stanley.mountain> (raw)

Hello Joel Fernandes,

Commit bd57ec707441 ("rcutorture: Perform more frequent testing of
->gpwrap") from Feb 16, 2025 (linux-next), leads to the following
Smatch static checker warning:

	kernel/rcu/rcutorture.c:4586 rcu_torture_init()
	warn: missing error code 'firsterr'

kernel/rcu/rcutorture.c
    4576                 if (torture_init_error(firsterr))
    4577                         goto unwind;
    4578         }
    4579         if (object_debug)
    4580                 rcu_test_debug_objects();
    4581         torture_init_end();
    4582         if (cur_ops->gp_slow_register && !WARN_ON_ONCE(!cur_ops->gp_slow_unregister))
    4583                 cur_ops->gp_slow_register(&rcu_fwd_cb_nodelay);
    4584 
    4585         if (cur_ops->set_gpwrap_lag && rcu_gpwrap_lag_init())
--> 4586                 goto unwind;

set an error code?

    4587 
    4588         return 0;
    4589 
    4590 unwind:
    4591         torture_init_end();
    4592         rcu_torture_cleanup();
    4593         if (shutdown_secs) {
    4594                 WARN_ON(!IS_MODULE(CONFIG_RCU_TORTURE_TEST));
    4595                 kernel_power_off();
    4596         }
    4597         return firsterr;
    4598 }

regards,
dan carpenter

             reply	other threads:[~2025-04-23  7:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23  7:17 Dan Carpenter [this message]
2025-04-23  7:19 ` [bug report] rcutorture: Perform more frequent testing of ->gpwrap Dan Carpenter
2025-04-24  0:41   ` Paul E. McKenney
2025-04-24  6:54     ` Dan Carpenter
2025-04-24 14:44       ` Paul E. McKenney
2025-04-24 15:17         ` Joel Fernandes
2025-04-24 18:14           ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAiT_KWYN-gP-2MN@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=joelagnelf@nvidia.com \
    --cc=rcu@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox