From: Frederic Weisbecker <frederic@kernel.org>
To: Joel Fernandes <joelagnelf@nvidia.com>
Cc: linux-kernel@vger.kernel.org,
"Paul E . McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
rcu@vger.kernel.org, Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Uladzislau Rezki <urezki@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang@linux.dev>
Subject: Re: [PATCH -next v2 4/4] rcu/nocb: Extract nocb_defer_wakeup_cancel() helper
Date: Fri, 16 Jan 2026 23:49:05 +0100 [thread overview]
Message-ID: <aWrAYTgIGZUbLA0Y@pavilion.home> (raw)
In-Reply-To: <20260114173154.1701056-5-joelagnelf@nvidia.com>
Le Wed, Jan 14, 2026 at 12:31:54PM -0500, Joel Fernandes a écrit :
> The pattern of checking nocb_defer_wakeup and deleting the timer is
> duplicated in __wake_nocb_gp() and nocb_gp_wait(). Extract this into a
> common helper function nocb_defer_wakeup_cancel().
>
> This removes code duplication and makes it easier to maintain.
>
> Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
--
Frederic Weisbecker
SUSE Labs
prev parent reply other threads:[~2026-01-16 22:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 17:31 [PATCH -next v2 0/4] rcu/nocb: Cleanup patches for next merge window Joel Fernandes
2026-01-14 17:31 ` [PATCH -next v2 1/4] rcu/nocb: Remove unnecessary WakeOvfIsDeferred wake path Joel Fernandes
2026-01-14 17:31 ` [PATCH -next v2 2/4] rcu/nocb: Add warning if no rcuog wake up attempt happened during overload Joel Fernandes
2026-01-16 14:42 ` joelagnelf
2026-01-16 21:56 ` Frederic Weisbecker
2026-01-19 22:04 ` Joel Fernandes
2026-01-14 17:31 ` [PATCH -next v2 3/4] rcu/nocb: Add warning to detect if overload advancement is ever useful Joel Fernandes
2026-01-16 22:42 ` Frederic Weisbecker
2026-01-19 21:34 ` Joel Fernandes
2026-01-14 17:31 ` [PATCH -next v2 4/4] rcu/nocb: Extract nocb_defer_wakeup_cancel() helper Joel Fernandes
2026-01-16 22:49 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWrAYTgIGZUbLA0Y@pavilion.home \
--to=frederic@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joelagnelf@nvidia.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang@linux.dev \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox