public inbox for rcu@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
	Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Boqun Feng <boqun@kernel.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Marco Elver <elver@google.com>, Arnd Bergmann <arnd@arndb.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Zqiang <qiang.zhang@linux.dev>, Vlastimil Babka <vbabka@suse.cz>,
	Harry Yoo <harry.yoo@oracle.com>,
	Menglong Dong <menglong8.dong@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: mark lockdep_assert_rcu_helper() __always_inline
Date: Mon, 2 Feb 2026 07:53:31 -0800	[thread overview]
Message-ID: <d648f1cf-f894-4354-81ba-81cd3cf21270@paulmck-laptop> (raw)
In-Reply-To: <20260202095507.1237440-1-arnd@kernel.org>

On Mon, Feb 02, 2026 at 10:55:01AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> There are some configurations in which lockdep_assert_rcu_helper() ends up
> not being inlined, for some reason. This leads to a link failure because
> now the caller tries to pass a nonexistant __ctx_lock_RCU structure:
> 
> ld: lib/test_context-analysis.o: in function `test_rcu_assert_variants':
> test_context-analysis.c:(.text+0x275c): undefined reference to `RCU'
> ld: test_context-analysis.c:(.text+0x276c): undefined reference to `RCU_BH'
> ld: test_context-analysis.c:(.text+0x2774): undefined reference to `RCU_SCHED'
> 
> I saw this in one out of many 32-bit arm builds using gcc-15.2, but
> it probably happens in others as well.
> 
> Mark this function as __always_inline to fix the build.
> 
> Fixes: fe00f6e84621 ("rcu: Support Clang's context analysis")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Paul E. McKenney <paulmck@kernel.org>

> ---
>  include/linux/rcupdate.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index ea1e979b290e..7729fef249e1 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -406,7 +406,7 @@ static inline void rcu_preempt_sleep_check(void) { }
>  
>  // See RCU_LOCKDEP_WARN() for an explanation of the double call to
>  // debug_lockdep_rcu_enabled().
> -static inline bool lockdep_assert_rcu_helper(bool c, const struct __ctx_lock_RCU *ctx)
> +static __always_inline bool lockdep_assert_rcu_helper(bool c, const struct __ctx_lock_RCU *ctx)
>  	__assumes_shared_ctx_lock(RCU) __assumes_shared_ctx_lock(ctx)
>  {
>  	return debug_lockdep_rcu_enabled() &&
> -- 
> 2.39.5
> 

      parent reply	other threads:[~2026-02-02 15:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  9:55 [PATCH] rcu: mark lockdep_assert_rcu_helper() __always_inline Arnd Bergmann
2026-02-02  9:58 ` Peter Zijlstra
2026-02-02 15:53 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d648f1cf-f894-4354-81ba-81cd3cf21270@paulmck-laptop \
    --to=paulmck@kernel.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=boqun@kernel.org \
    --cc=elver@google.com \
    --cc=frederic@kernel.org \
    --cc=harry.yoo@oracle.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jiangshanlai@gmail.com \
    --cc=joelagnelf@nvidia.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=menglong8.dong@gmail.com \
    --cc=neeraj.upadhyay@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qiang.zhang@linux.dev \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox