From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 228DE33B6F8 for ; Fri, 19 Dec 2025 21:28:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766179734; cv=none; b=SZK5xPGpYTXeKrV8FakV0YIjDXUcjkLElk6IOPP0RpRrQg0rYLtN4Gv5UNSmIwLEd5UzzwQCjIEJBDOOHwaJvpmqn8JUm8f8MGm94Y3ikuUxV6esrGDqQpQP1fPKyGsZsgqS05Jjz2Z87VaMIMaSa06L/7/rvJNR9nZ+LPO+d9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766179734; c=relaxed/simple; bh=9qdyLYhk6D9KpgNEc9lTRHJNMgr66Y5zIziSEMCrXTM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AyiiP+lcKI9VoPhyOHfSNvQ/jfgazDJ5y+2ft85t7ibIJ00CQy9/hyvJIXyCEiRfZkjn6xQpOYcsk3mRCL1keDrf4W0yfOlSxmJtoLkFPs6cfXBPk0l3I3wYeU1Q18mvldexc+/VMGU0W74EK5ISND31rEEOf/Zm2NEVKonHSkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RMtyxVaH; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RMtyxVaH" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-7ba55660769so1867341b3a.1 for ; Fri, 19 Dec 2025 13:28:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766179731; x=1766784531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9qdyLYhk6D9KpgNEc9lTRHJNMgr66Y5zIziSEMCrXTM=; b=RMtyxVaHlb4x5czCBEyOx56xfjT+RNoyzgmUIOLM8rQyyjHAn8b14RHWVg+U9yECU2 DNet9BX2LSDx+fbfhj2eagJwVgKFUN3paA/J0jVpzr17MqrPGIkC8uWMpzr25M5n/Svh riLL7VUKYl3lLur1iiIDnUxqZzSyVldJOlWErwA4BYTCmBjZa+IIIv/4tggBwnPyd5N1 4sP+EomK5LaRfaouO3drpoA8BG7gNbSc2L4KFhFCx08iZDlPsih1J+3De+KvkTA6nBjx xSBUnB9EV5NlQAOueOI5ovsh9ZrpK2mKI2rYqZMt2HvppVyMTV6Z5xJIcetFL+mvKY9C JWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766179731; x=1766784531; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9qdyLYhk6D9KpgNEc9lTRHJNMgr66Y5zIziSEMCrXTM=; b=DKZ0eJjXNCgQS2X/ofTHZIfA+YIyN6ZswmiF3HF8G0eqe52YfdEZFtZ9+EbJhx0TX/ LJdfNEy83oAn4u4ocQ9PnuT2cpCo78Aiaa9UerBFYmzJObag91WWRPk81skVfO0BGJlS f+DzvsHEhC9XawnRt3pyGL3cl537rBBWwoUE44ocjFVr9jpKA/e/unxoTSgTUu1iyHo6 TxdoAvVOt45xB5jSbbS0ldK/bq53+w6hmW9srJSYgygH7LVI86HWCQ/ShKY56BMDBvN4 aterDA+d0dZIS3Gecl27sZJAblcSwDObAJQjUcZidR3m17D1KynoQyL4alQYOyzb8p9p BwlQ== X-Forwarded-Encrypted: i=1; AJvYcCUt+36BiYQkWv0yGsplUc1phnDgRN4egDQgeVg4J4uCZnP2hhUExt4MntajGaQcBfCZ3k8=@vger.kernel.org X-Gm-Message-State: AOJu0YwSxCa47u6MPbrSDD0MdZpbSo60SKFGfpK3juxfml0Mal+DpL9K SMyWbJAygSNUzW8rXulVYK521g0lRIh8mkqlV2ltxR2NS5tvUEblBQdg X-Gm-Gg: AY/fxX53odaYw++Td/168J7EQuA849yzI7l0zd27HIY1iJtmId4NlKC+hYhSu4/whrY pxag+kfGHwjs9z9BseSnN+lSERnREtpajyBMicK6gZJPWG0Ev2HzW6ehJ1OsEd3YhP5oBPmrq4W 1jn74i4bHXURocBz8MepyF3nTwG67aGaK+H3DAmTvpuEw1b4fVckYnFwYKjfGhza6dUxhmSs2DQ Ixoc0VtRGaXwbGYqWkzoIYho9KMtTdbqTd90sal0JVyeaZ9piFV9wqQH45MTrTHcfhAwHLXQGUh 01LXPgLSiQ+ARBp1nxsuVe5SuLXARlnz6/xyMvyvHvd2cv6MBdff/PSwlFlIYd2WxLU1/QRTGDz 36tPDAeZUp1CDmzVB5uaBLfcqFLVXtuRIMPwZze2j3CU1m7XTQOiITrVPxLWGaPUeetCY+m2kuA 1YPyawNVddm1IdLyPY+V6art+udKpvPD4kzemT0FIOnx9PwbWAs7C1Hcl5CjYDtnPbhJojX0rwS VJkO8k8c08iVsln4YCExLenV44DE7nfpArq11XTp4iDDVAIAnl3eMLXF31MVb3ITeQXFVNmkzGZ PJw= X-Google-Smtp-Source: AGHT+IFntC97OMoIKW8iak4Csi+Sa/wJHZS2qz46SkDovenEuEnw3BILL/ha2LHm12T/rhrLMeYBbA== X-Received: by 2002:a05:7022:6988:b0:119:e56b:91ed with SMTP id a92af1059eb24-121722e01c2mr4354548c88.30.1766179731046; Fri, 19 Dec 2025 13:28:51 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:5874:79f3:80da:a7a3? ([2a00:79e0:2e7c:8:5874:79f3:80da:a7a3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1217254cd77sm12305503c88.14.2025.12.19.13.28.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 13:28:50 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 14:28:48 -0700 Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/36] lockdep: Annotate lockdep assertions for context analysis To: Marco Elver Cc: Peter Zijlstra , Boqun Feng , Ingo Molnar , Will Deacon , "David S. Miller" , Luc Van Oostenryck , Chris Li , "Paul E. McKenney" , Alexander Potapenko , Arnd Bergmann , Christoph Hellwig , Dmitry Vyukov , Eric Dumazet , Frederic Weisbecker , Greg Kroah-Hartman , Herbert Xu , Ian Rogers , Jann Horn , Joel Fernandes , Johannes Berg , Jonathan Corbet , Josh Triplett , Justin Stitt , Kees Cook , Kentaro Takeda , Lukas Bulwahn , Mark Rutland , Mathieu Desnoyers , Miguel Ojeda , Nathan Chancellor , Neeraj Upadhyay , Nick Desaulniers , Steven Rostedt , Tetsuo Handa , Thomas Gleixner , Thomas Graf , Uladzislau Rezki , Waiman Long , kasan-dev@googlegroups.com, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-sparse@vger.kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, rcu@vger.kernel.org References: <20251219154418.3592607-1-elver@google.com> <20251219154418.3592607-8-elver@google.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/25 2:16 PM, Marco Elver wrote: > It's basically an escape hatch to defer to dynamic analysis where the > limits of the static analysis are reached. That's not how lockdep_assert_held() is used in the kernel. This macro is more often than not used to document assumptions that can be verified at compile time. This patch seems like a step in the wrong direction to me because it *suppresses* compile time analysis compile-time analysis is useful. I think that this patch either should be dropped or that the __assume() annotations should be changed into __must_hold() annotations. Bart.