From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73C33C8EC for ; Mon, 15 May 2023 13:39:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9C08821C3D; Mon, 15 May 2023 13:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684157990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NdD+9F73a1JS19ma9M2nove4HcijJ9yFsVmb4aGVZcc=; b=BcztabH5QC++MdEKV3K1+zOxP6OWeApIQ4XWGM1A/Fv1EWqLcEXpIPEgzw8FOJHn5gwM2H 24tgUnpuaVNZwwIpLLjOHr3vXjdimWlvmpTC1c9tbZKLltQHbpUAUtz93WXbtXDmHXUC2V RkOM3J3m8iwUiVMKfB/UP1k9M1fy0Eg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684157990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NdD+9F73a1JS19ma9M2nove4HcijJ9yFsVmb4aGVZcc=; b=qsVZTHcfig2RpF1wQUPUppfHKlCGrvqsgpK912mb5WqDHYJQVJSh7xcX1b4SYkeD3gi8xt h0Oj4wWucaGhzKAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 667EF138E5; Mon, 15 May 2023 13:39:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0X7dFyY2YmSlTQAAMHmgww (envelope-from ); Mon, 15 May 2023 13:39:50 +0000 Date: Mon, 15 May 2023 15:39:49 +0200 Message-ID: <874jodlnmi.wl-tiwai@suse.de> From: Takashi Iwai To: "Joseph C. Sible" Cc: Bagas Sanjaya , regressions@lists.linux.dev, kailang@realtek.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot In-Reply-To: References: <87cz338ix4.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII On Sun, 14 May 2023 23:48:55 +0200, Joseph C. Sible wrote: > > On 5/14/23, Takashi Iwai wrote: > > The patch changes two places (the change in alc_shutup_pins() and > > alc256_shutup()), and I guess the latter is the culprit. Could you > > verify that only reverting the latter fixes the problem? > > Yes, only reverting the latter fixes the problem. I just tried a > kernel consisting of 6.3.2 plus the below change, and it works fine: > > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -3638,8 +3638,7 @@ static void alc256_shutup(struct hda_codec *codec) > /* If disable 3k pulldown control for alc257, the Mic > detection will not work correctly > * when booting with headset plugged. So skip setting it for > the codec alc257 > */ > - if (codec->core.vendor_id != 0x10ec0236 && > - codec->core.vendor_id != 0x10ec0257) > + if (codec->core.vendor_id != 0x10ec0257) > alc_update_coef_idx(codec, 0x46, 0, 3 << 12); > > if (!spec->no_shutup_pins) OK, thanks for confirmation. Kailang, could you check this issue? Judging from the comment there: /* 3k pull low control for Headset jack. */ /* NOTE: call this before clearing the pin, otherwise codec stalls */ /* If disable 3k pulldown control for alc257, the Mic detection will not work correctly * when booting with headset plugged. So skip setting it for the codec alc257 */ ... it seems that the codec got screwed with this setup, which leaded to the non-response at the probe after reboot. In the worst case, I'll revert that part. thanks, Takashi