From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ABE4C8F4 for ; Wed, 24 May 2023 10:16:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9606B1F45F; Wed, 24 May 2023 10:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684923410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zttj4265y2tK/w+ymfGwU9nqseVLNqS6aHowZnIqk18=; b=QN104DB2Qo5wHo5pITkMoFrwIDNDS/CJBBddwmJbaRh63aj4f5/esqTq0fzrkJc4Epdsia IYbS8ovt9rRCqJjrOCTKrQoY0WGpi4kn5h7/YxOb3o2S82Zj/7cQRJh4r3IiTCAzzBXylo OOmkUbLnZ7K9hlLiORTZxyGtTsPLDEs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684923410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zttj4265y2tK/w+ymfGwU9nqseVLNqS6aHowZnIqk18=; b=arA3ctFdkWhFtKl81yuRmcLg3pAxTETekhLKmrFjpemmNbnDjufyhnoEh8EXV8MrbDH8CT pBESrN/tdXXjZsAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6821613425; Wed, 24 May 2023 10:16:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bl95GBLkbWTvHAAAMHmgww (envelope-from ); Wed, 24 May 2023 10:16:50 +0000 Date: Wed, 24 May 2023 12:16:49 +0200 Message-ID: <87fs7mdofi.wl-tiwai@suse.de> From: Takashi Iwai To: Kailang Cc: "Joseph C. Sible" , Bagas Sanjaya , "regressions@lists.linux.dev" , "perex@perex.cz" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot In-Reply-To: <415d4bc84aa74c74af913048f28b42a9@realtek.com> References: <87cz338ix4.wl-tiwai@suse.de> <874jodlnmi.wl-tiwai@suse.de> <415d4bc84aa74c74af913048f28b42a9@realtek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII On Thu, 18 May 2023 07:44:23 +0200, Kailang wrote: > > > -----Original Message----- > > From: Takashi Iwai > > Sent: Monday, May 15, 2023 9:40 PM > > To: Joseph C. Sible > > Cc: Bagas Sanjaya ; regressions@lists.linux.dev; > > Kailang ; perex@perex.cz; tiwai@suse.com; > > alsa-devel@alsa-project.org > > Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP > > 15z-fc000 on warm boot > > > > > > External mail. > > > > > > > > On Sun, 14 May 2023 23:48:55 +0200, > > Joseph C. Sible wrote: > > > > > > On 5/14/23, Takashi Iwai wrote: > > > > The patch changes two places (the change in alc_shutup_pins() and > > > > alc256_shutup()), and I guess the latter is the culprit. Could you > > > > verify that only reverting the latter fixes the problem? > > > > > > Yes, only reverting the latter fixes the problem. I just tried a > > > kernel consisting of 6.3.2 plus the below change, and it works fine: > > > > > > --- a/sound/pci/hda/patch_realtek.c > > > +++ b/sound/pci/hda/patch_realtek.c > > > @@ -3638,8 +3638,7 @@ static void alc256_shutup(struct hda_codec > > *codec) > > > /* If disable 3k pulldown control for alc257, the Mic > > > detection will not work correctly > > > * when booting with headset plugged. So skip setting it for > > > the codec alc257 > > > */ > > > - if (codec->core.vendor_id != 0x10ec0236 && > > > - codec->core.vendor_id != 0x10ec0257) > > > + if (codec->core.vendor_id != 0x10ec0257) > > > alc_update_coef_idx(codec, 0x46, 0, 3 << 12); > > > > > > if (!spec->no_shutup_pins) > > > > OK, thanks for confirmation. > > > > Kailang, could you check this issue? > > OK. I will take it a look for these days. Kailang, any chance to get this fixed? Otherwise I'll revert the commit as a temporary solution at first. You can re-apply the change (with the proper workaround for this problem) later, too. thanks, Takashi