From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1047618AFE for ; Mon, 31 Jul 2023 16:14:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6D4A81F854; Mon, 31 Jul 2023 16:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690820079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2FPdvVJdYdtOHQsKLQpCAb/yeA5uJ3rxVC2Q1LTBHKs=; b=rUzOmdPzBoAVPHEFZ8/BZFHzOOB1JhJ4VXdTppltLTFlTY5HBTXyE0iUWfZd4ZX9O2CCwi wjczEqRgYsHZmX833c1GvprLht48uk0lZ3tbMReVKsL7tdm2E7brjVQpShSs7xIBX0qUaY CUDQE8Ry5k1hFWImGj+9FrnbXmm0fdQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690820079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2FPdvVJdYdtOHQsKLQpCAb/yeA5uJ3rxVC2Q1LTBHKs=; b=9H0Vga1SoaCmt4UMa04L5AHwlWfZtjWyWkK06GmWA9QGpF1LqT/vXNom/YzSkfSNZ9LI4c pHfjzn6qVrk0AaCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0DD6A1322C; Mon, 31 Jul 2023 16:14:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tNCCAu/dx2S7DQAAMHmgww (envelope-from ); Mon, 31 Jul 2023 16:14:39 +0000 Date: Mon, 31 Jul 2023 18:14:38 +0200 Message-ID: <87o7jshxch.wl-tiwai@suse.de> From: Takashi Iwai To: Kailang Cc: "Joseph C. Sible" , Bagas Sanjaya , "regressions@lists.linux.dev" , "perex@perex.cz" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot In-Reply-To: <878rbjdofa.wl-tiwai@suse.de> References: <87cz338ix4.wl-tiwai@suse.de> <874jodlnmi.wl-tiwai@suse.de> <415d4bc84aa74c74af913048f28b42a9@realtek.com> <87fs7mdofi.wl-tiwai@suse.de> <7da2fdfdae614b1c98deda6e11ca34eb@realtek.com> <87353kd8b9.wl-tiwai@suse.de> <1170325957764b4cbd7cd3639575f285@realtek.com> <873536js7q.wl-tiwai@suse.de> <2c1fcbc00bb44d66a29ac1c1e4bec5ad@realtek.com> <485f99149508488080d563144454040e@realtek.com> <2831c55638a5431ca9e37d9caf365ed2@realtek.com> <3c27f0455d6e4bd1a68115bd25bf1a12@realtek.com> <009474f04d0b45c69a0e42e8622b7a86@realtek.com> <87h6rhcef2.wl-tiwai@suse.de> <0990300d759846d890de9c92fcad9a9d@realtek.com> <878rctcavz.wl-tiwai@suse.de> <874jnhc9u4.wl-tiwai@suse.de> <875y7vbxpg.wl-tiwai@suse.de> <87wn0aa1s4.wl-tiwai@suse.de> <87leg7x4h7.wl-tiwai@suse.de> <87cz182hfk.wl-tiwai@suse.de> <4678992299664babac4403d9978e7ba7@realtek.com> <1f83caa215ad4374aec8859c70044b00@realtek.com> <878rbjdofa.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII On Fri, 14 Jul 2023 07:58:49 +0200, Takashi Iwai wrote: > > On Fri, 14 Jul 2023 04:46:25 +0200, > Kailang wrote: > > > > Hi Takashi, > > > > Could you agree this workaround? > > Yes, looks fine. I applied it now. ... and now we receive a regression report due to this change :-< https://bugzilla.kernel.org/show_bug.cgi?id=217732 I believe the problem is that the patch disabled the 3kpull-low behavior too much while some codecs still need it. The patch changes like: @@ -3638,8 +3640,7 @@ static void alc256_shutup(struct hda_codec *codec) /* If disable 3k pulldown control for alc257, the Mic detection will not work correctly * when booting with headset plugged. So skip setting it for the codec alc257 */ - if (codec->core.vendor_id != 0x10ec0236 && - codec->core.vendor_id != 0x10ec0257) + if (spec->en_3kpull_low) alc_update_coef_idx(codec, 0x46, 0, 3 << 12); if (!spec->no_shutup_pins) ... while the only place setting spec->en_3kpull_low is: @@ -10682,6 +10683,8 @@ static int patch_alc269(struct hda_codec *codec) spec->shutup = alc256_shutup; spec->init_hook = alc256_init; spec->gen.mixer_nid = 0; /* ALC256 does not have any loopback mixer path */ + if (codec->bus->pci->vendor == PCI_VENDOR_ID_AMD) + spec->en_3kpull_low = true; break; case 0x10ec0257: spec->codec_variant = ALC269_TYPE_ALC257; Since spec->3n_3kpull_low is false as default, it means that, except for ALC230/236/256 and PCI vendor AMD, the flag is never set, hence it's no longer called. Shouldn't spec->en_3kpull_low be enabled rather as default? Or which models can set it? thanks, Takashi