From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2553238B for ; Sun, 29 Oct 2023 01:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zh7DgOSN" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6b36e1fcee9so2950109b3a.3 for ; Sat, 28 Oct 2023 18:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698544128; x=1699148928; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=auatwq7IukONekRjkD8fy/r6M5PY6yplZ8A6BcVgrik=; b=Zh7DgOSN60hzEEU+Ptth8gWHPxSfeaS9E5bhix37xHhsmC4YwSM/v+oGEwhzbLgQoD siCfBe9/E1aEvFxJqjoKO2mMpCaBrlIlwh3t5SuAVCeRVyVmQs+KyThdPJ43/DEe5odl aD7buH2UEtviQ+aqbyEukNuab3n178vFAPPYXDWj/vfjB69+pfYFujVlHZU0YeakmnQP CSXHLaAAyl3IEN623reSbGOctnlM+71OJohuIBIEPL5y772RW75lSCNHnJF4AVZMEiUP 5mSLlR1ekIHxgWAvn1mRt0/79WkQgvpuAqg+csJEe34SmCWLjcRYsmZFHLI6ouxyBwtY kHsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698544128; x=1699148928; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=auatwq7IukONekRjkD8fy/r6M5PY6yplZ8A6BcVgrik=; b=nXm4PQFLFw+5VkxKmVwDlOvvtJjd23AI+4FbRGaixiqzett5H/EZVT741u3obfVCGT gtcIyuNpaWpca/w48um/A3fbmqloIcPjhdAwJTROwJEd1+yuSmNsq8Dkv7F0sDM3tncN HTkbOfllR06udYHX88pD9u/KR4br2HZPI/CVYKJgSHFUbt9QAin5o0MQNi+ASVz/EgO0 QqVdIGXtZquTfa9XrvUaJCk2Njwf/1dt1Gcfon27C/lvoDCKoXogBYQGVOMoeCv2QOOW esVZubnFjn2kENPAuXlJLzfxvC/TMJJh+ZenTYCpVwsjHk56K4mzFskCW028eGmowOBm 2Iwg== X-Gm-Message-State: AOJu0Ywr6d2vx1/wqZb5u08roG/7RwWMs9BjF8Ss46Pwk9sxrauf71+X uXk6HT1dm3Rbm7xcClkCASQ= X-Google-Smtp-Source: AGHT+IEmW7h54d/bTZdjJ6PyNgjOmZfb752KgVjw8p6echz5SgbZih3/FuM6WBOgDx4mD+Ik3rg9eA== X-Received: by 2002:a17:902:e5cf:b0:1cc:3c6c:ce23 with SMTP id u15-20020a170902e5cf00b001cc3c6cce23mr879901plf.42.1698544128240; Sat, 28 Oct 2023 18:48:48 -0700 (PDT) Received: from debian.me ([103.131.18.64]) by smtp.gmail.com with ESMTPSA id q16-20020a170902dad000b001b8baa83639sm3759894plx.200.2023.10.28.18.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Oct 2023 18:48:47 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id 98A0E8047BCA; Sun, 29 Oct 2023 08:48:43 +0700 (WIB) Date: Sun, 29 Oct 2023 08:48:42 +0700 From: Bagas Sanjaya To: Linux Kernel Mailing List , Linux Regressions , Linux Hardware Monitoring , Linux x86 Platform Drivers , Linux LEDs Cc: Tim Crawford , Jeremy Soller , System76 Product Development , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Mark Gross , Jean Delvare , Guenter Roeck , Jean-Jacques Hiblot , Lee Jones , Pavel Machek , Johannes =?utf-8?Q?Pen=C3=9Fel?= Subject: Re: Fwd: sysfs: cannot create duplicate filename .../system76_acpi::kbd_backlight/color Message-ID: References: Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l1HHIbidedQ4JpqX" Content-Disposition: inline In-Reply-To: --l1HHIbidedQ4JpqX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 26, 2023 at 02:55:06PM +0700, Bagas Sanjaya wrote: > Hi, >=20 > I notice a regression report on Bugzilla [1]. Quoting from it: >=20 > > Loading the system76-acpi kernel module fails on linux 6.6-rc7. This do= es not seem to be an issue with system76-acpi itself, because reverting com= mit #5d36931f0fe51665c04f56c027613d22e6a03411, which is the only change mad= e to this driver across the 6.6 development cycle, does not fix the issue. = On 6.5.8, everything works fine. My hardware is a Clevo-based Alder Lake la= ptop running coreboot, roughly similar to the System76 Darter Pro 8. > >=20 > > backtrace: > > [ 266.399036] sysfs: cannot create duplicate filename '/devices/LNXSYS= TM:00/LNXSYBUS:00/17761776:00/leds/system76_acpi::kbd_backlight/color' > > [ 266.399045] CPU: 1 PID: 2896 Comm: modprobe Not tainted 6.6.0-rc7 #1 > > [ 266.399050] Hardware name: Notebook NS5x_NS7xPU/NS5x_NS7xPU, BIOS Da= sharo (coreboot+UEFI) v1.6.0 03/30/2023 > > [ 266.399053] Call Trace: > > [ 266.399057] > > [ 266.399063] dump_stack_lvl+0x36/0x50 > > [ 266.399080] sysfs_warn_dup+0x5a/0x70 > > [ 266.399088] sysfs_add_file_mode_ns+0x11a/0x130 > > [ 266.399094] internal_create_group+0x125/0x3b0 > > [ 266.399101] internal_create_groups+0x42/0xa0 > > [ 266.399107] device_add+0x5b1/0x8a0 > > [ 266.399113] ? kstrdup+0x4c/0x70 > > [ 266.399119] device_create_groups_vargs+0xce/0xf0 > > [ 266.399124] device_create_with_groups+0x4b/0x70 > > [ 266.399129] led_classdev_register_ext+0x1d2/0x470 [led_class] > > [ 266.399149] ? devm_led_classdev_register_ext+0x3a/0x90 [led_class] > > [ 266.399162] devm_led_classdev_register_ext+0x50/0x90 [led_class] > > [ 266.399173] system76_add+0x18b/0x460 [system76_acpi] > > [ 266.399186] acpi_device_probe+0x47/0x130 > > [ 266.399193] really_probe+0x19b/0x3e0 > > [ 266.399199] ? __pfx___driver_attach+0x10/0x10 > > [ 266.399205] __driver_probe_device+0x78/0x160 > > [ 266.399211] driver_probe_device+0x1f/0x90 > > [ 266.399217] __driver_attach+0xd2/0x1c0 > > [ 266.399222] bus_for_each_dev+0x85/0xd0 > > [ 266.399227] bus_add_driver+0x116/0x220 > > [ 266.399233] driver_register+0x59/0x100 > > [ 266.399242] ? __pfx_system76_driver_init+0x10/0x10 [system76_acpi] > > [ 266.399252] do_one_initcall+0x5a/0x300 > > [ 266.399260] do_init_module+0x60/0x240 > > [ 266.399267] init_module_from_file+0x86/0xc0 > > [ 266.399275] __x64_sys_finit_module+0x18a/0x350 > > [ 266.399282] do_syscall_64+0x5d/0x90 > > [ 266.399289] ? syscall_exit_to_user_mode+0x26/0x40 > > [ 266.399295] ? do_syscall_64+0x6c/0x90 > > [ 266.399300] ? do_syscall_64+0x6c/0x90 > > [ 266.399305] entry_SYSCALL_64_after_hwframe+0x6e/0xd8 > > [ 266.399314] RIP: 0033:0x7f5c11b38d7d > > [ 266.399360] Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa= 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05= <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 7b d0 0b 00 f7 d8 64 89 01 48 > > [ 266.399364] RSP: 002b:00007ffe30e15b88 EFLAGS: 00000246 ORIG_RAX: 00= 00000000000139 > > [ 266.399370] RAX: ffffffffffffffda RBX: 000055a8d48d6c10 RCX: 00007f5= c11b38d7d > > [ 266.399372] RDX: 0000000000000000 RSI: 000055a8d3077d8b RDI: 0000000= 000000003 > > [ 266.399375] RBP: 000055a8d3077d8b R08: 00007f5c11bf6b00 R09: 00007ff= e30e15bd0 > > [ 266.399376] R10: 0000000000000050 R11: 0000000000000246 R12: 0000000= 000040000 > > [ 266.399378] R13: 000055a8d48d6c90 R14: 000055a8d48d6390 R15: 000055a= 8d48d7090 > > [ 266.399382] > > [ 266.399410] System76 ACPI Driver: probe of 17761776:00 failed with e= rror -17 >=20 > See Bugzilla for the full thread and attached dmesg output. >=20 > Anyway, I'm adding this regression to regzbot: >=20 > #regzbot introduced: v6.5..v6.6-rc7 https://bugzilla.kernel.org/show_bug.= cgi?id=3D218045 >=20 The reporter had narrowed down the culprit. He said on Bugzilla: > The culprit seems to be commit c7d80059b086c4986cd994a1973ec7a5d75f8eea, = which introduces a new 'color' attribute for led sysfs class devices. The p= roblem is that the system76-acpi platform driver tries to create the exact = same sysfs attribute itself for the system76_acpi::kbd_backlight device, le= ading to the conflict. For testing purposes, I've just rebuilt the kernel w= ith the system76-apci color attribute renamed to kb_color, and that fixes t= he issue. Jean-Jacques Hiblot, would you like to take a look on this regression, since you authored the culprit? Anyway, telling regzbot: #regzbot introduced: c7d80059b086c4 Thanks. --=20 An old man doll... just what I always wanted! - Clara --l1HHIbidedQ4JpqX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZT259QAKCRD2uYlJVVFO o1aLAQCTcxJzAz7z6gQE5PYbKcSC6KTszCtvXejFOdoLJXcb6wEAiDFpigyZ7u4l WkPd9Z5tgzenEgsZPGAbF5PNFtKr+wk= =pa9Q -----END PGP SIGNATURE----- --l1HHIbidedQ4JpqX--